Bug 54076 - [GTK] Add new files to compilation after r77974
Summary: [GTK] Add new files to compilation after r77974
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 52805
  Show dependency treegraph
Reported: 2011-02-09 00:54 PST by Alejandro G. Castro
Modified: 2011-03-08 10:43 PST (History)
3 users (show)

See Also:

Proposed patch (4.10 KB, patch)
2011-02-09 00:57 PST, Alejandro G. Castro
no flags Details | Formatted Diff | Diff
Proposed patch (5.72 KB, patch)
2011-03-08 04:33 PST, Alejandro G. Castro
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2011-02-09 00:54:15 PST
New code to allow passing context to policy delegate methods: bug 54031
Comment 1 Alejandro G. Castro 2011-02-09 00:57:24 PST
Created attachment 81765 [details]
Proposed patch
Comment 2 Alejandro G. Castro 2011-02-09 06:18:20 PST
Comment on attachment 81765 [details]
Proposed patch

Just found r77974 causes problems with the page loading, probably we will need to do more things in this patch to make it work.
Comment 3 Martin Robinson 2011-03-07 11:37:22 PST
What's the status on this issue?
Comment 4 Alejandro G. Castro 2011-03-07 12:14:14 PST
(In reply to comment #3)
> What's the status on this issue?

We still need to check the policy handling and fix the problem that causes the problem loading, not sure but could be an easy fix, just some method not implemented of no correctly doing what it should. You can check that applying the patch compilations works but the rendering does not happen and reverting the patch you get the rendering correctly.
Comment 5 Alejandro G. Castro 2011-03-08 03:07:15 PST
I had to check this issue now because after the last patches we can not easily avoid it.

Apparently decidePolicyForNavigationAction message does not work, for some reason, sendSync returns false. I've checked that discarding the return value and passing PolicyUse directly to the frame everything works. Not sure how to to test the message issues, adding people to the CC that probably know how to do it.
Comment 6 Alejandro G. Castro 2011-03-08 04:07:35 PST
I think I found the issue, we have to implement the encode/decodeResourceRequest and resourceResponse.
Comment 7 Alejandro G. Castro 2011-03-08 04:33:49 PST
Created attachment 85042 [details]
Proposed patch

Added dummy encoders just so make it work and added a bug to implement the proper support: bug 55934
Comment 8 Alejandro G. Castro 2011-03-08 10:43:40 PST
Thanks for the review Matin, landed http://trac.webkit.org/changeset/80571