Bug 54031 - WK2: Add ability to pass context to policy delegate methods
Summary: WK2: Add ability to pass context to policy delegate methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-08 13:43 PST by Sam Weinig
Modified: 2011-02-08 14:48 PST (History)
2 users (show)

See Also:

Attachments
Patch (80.22 KB, patch)
2011-02-08 14:10 PST, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-02-08 13:43:50 PST 
WK2: Add ability to pass context to policy delegate methods
Comment 1 Sam Weinig 2011-02-08 14:10:18 PST 
Created attachment 81689 [details]
Patch
Comment 2 WebKit Review Bot 2011-02-08 14:11:50 PST 
Attachment 81689 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleNavigationAction.h:38:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebKit2/UIProcess/WebPolicyClient.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2011-02-08 14:41:09 PST 
Attachment 81689 [details] did not build on win:
Build output: http://queues.webkit.org/results/7858004
Comment 4 Sam Weinig 2011-02-08 14:48:46 PST 
Landed in r77974.