Bug 54073 - [GTK] Missing layoutTestController.displayInvalidatedRegion()
Summary: [GTK] Missing layoutTestController.displayInvalidatedRegion()
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2011-02-09 00:04 PST by Martin Robinson
Modified: 2022-04-19 01:17 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.43 KB, patch)
2012-03-23 07:33 PDT, Adrian Perez
pnormand: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2011-02-09 00:04:43 PST
http://trac.webkit.org/changeset/78010 added  layoutTestController.displayInvalidatedRegion, but not to the GTK+ DRT. We should skip layoutTestController.displayInvalidatedRegion until this functionality is in the DRT.
Comment 1 Adrian Perez 2012-03-23 07:33:22 PDT
Created attachment 133482 [details]
Patch
Comment 2 Martin Robinson 2012-03-23 07:42:23 PDT
Comment on attachment 133482 [details]
Patch

How is this test working? Does displayWebView doesn't only display the invalidated region on GTK+?
Comment 3 Philippe Normand 2012-04-12 09:01:46 PDT
Comment on attachment 133482 [details]
Patch

Skipped file was removed and indeed I could observe this test passing on 64-bit Release bot. Should we close this bug? The failure is now marked in test_expectations.txt btw.
Comment 4 Martin Robinson 2012-04-12 10:23:21 PDT
(In reply to comment #3)
> (From update of attachment 133482 [details])
> Skipped file was removed and indeed I could observe this test passing on 64-bit Release bot. Should we close this bug? The failure is now marked in test_expectations.txt btw.

The difference may only show up in pixel results, so we should double-check before closing the bug.
Comment 5 Zan Dobersek 2012-05-05 09:54:26 PDT
The tests covered by this bug were found to be passing consistently after moving from using the Skipped list to using test_expectations.txt. Their expectations were removed in r116122[1] (covered by bug #85591).

Comment #4 indicates that the problem is only observable in pixel output. Not closing the bug, but will reconsider reinstating the expectation (a PASS) in test_expectations.txt just to note that there actually is a problem with this test.

1: http://trac.webkit.org/changeset/116122
Comment 6 Martin Robinson 2022-04-19 01:17:21 PDT
This API was replaced by `displayAndTrackRepaints` and is implemented by the platform-independent WebKitTestRunner now.