Bug 54073 – [GTK] Missing layoutTestController.displayInvalidatedRegion()

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKitGTK

[Martin Robinson]

http://trac.webkit.org/changeset/78010 added  layoutTestController.displayInvalidatedRegion, but not to the GTK+ DRT. We should skip layoutTestController.displayInvalidatedRegion until this functionality is in the DRT.

[Adrian Perez]

Created attachment 133482 [details]
Patch

[Martin Robinson]

Comment on attachment 133482 [details]
Patch

How is this test working? Does displayWebView doesn't only display the invalidated region on GTK+?

[Philippe Normand]

Comment on attachment 133482 [details]
Patch

Skipped file was removed and indeed I could observe this test passing on 64-bit Release bot. Should we close this bug? The failure is now marked in test_expectations.txt btw.

[Martin Robinson]

(In reply to comment #3)
> (From update of attachment 133482 [details])
> Skipped file was removed and indeed I could observe this test passing on 64-bit Release bot. Should we close this bug? The failure is now marked in test_expectations.txt btw.

The difference may only show up in pixel results, so we should double-check before closing the bug.

[Zan Dobersek]

The tests covered by this bug were found to be passing consistently after moving from using the Skipped list to using test_expectations.txt. Their expectations were removed in r116122[1] (covered by bug #85591).

Comment #4 indicates that the problem is only observable in pixel output. Not closing the bug, but will reconsider reinstating the expectation (a PASS) in test_expectations.txt just to note that there actually is a problem with this test.

1: http://trac.webkit.org/changeset/116122

[Martin Robinson]

This API was replaced by `displayAndTrackRepaints` and is implemented by the platform-independent WebKitTestRunner now.