WebKit/EFL can choose GLIB_SUPPORT because of many reason. However, I believe that WebKit/EFL doesn't need to have GDK dependency.
Created attachment 81593 [details] Patch
Created attachment 81759 [details] same_patch_for_efl_bot
Comment on attachment 81759 [details] same_patch_for_efl_bot Looks like the freetype fonts with cairo still need Gdk. Can you take a look at this please?
(In reply to comment #3) > (From update of attachment 81759 [details]) > Looks like the freetype fonts with cairo still need Gdk. Can you take a look at this please? I don't know why, but efl bot try to build with PLATFORM(GTK). As following a build log, error position is what I removed EFL related macro for blocking GDK. I asked gyuyoung to solve. After resetting it, I'll try once more. Thank you.
Created attachment 82105 [details] Patch
(In reply to comment #5) > Created an attachment (id=82105) [details] > Patch gyuyoung, I don't know why it still failed. :( It is fine in my environment.
Are you using "cmake ../Source -DPORT=Efl" command to build WebKit ? EFL EWS is using this build command, cd In Tools/Scripts ./build-webkit --efl --release --args="-j8" Could you build WebKit with above command ?
(In reply to comment #7) > Are you using "cmake ../Source -DPORT=Efl" command to build WebKit ? yes. I use it. > > EFL EWS is using this build command, > > cd In Tools/Scripts > ./build-webkit --efl --release --args="-j8" > > Could you build WebKit with above command ? Tested, but I couldn't get build break.
(In reply to comment #8) > (In reply to comment #7) > > Are you using "cmake ../Source -DPORT=Efl" command to build WebKit ? > > yes. I use it. > > > > > EFL EWS is using this build command, > > > > cd In Tools/Scripts > > ./build-webkit --efl --release --args="-j8" > > > > Could you build WebKit with above command ? > > Tested, but I couldn't get build break. Hmm, other patches are built by EWS successfully. Now, I don't know the reason :-(, let's find the reason.
Comment on attachment 82105 [details] Patch EFL EWS wasn't happy with this patch.
(In reply to comment #10) > (From update of attachment 82105 [details]) > EFL EWS wasn't happy with this patch. Can someone else test the patch on his EFL machine? Strange if it works on one machine, but doesn't on the bot.
(In reply to comment #11) > (In reply to comment #10) > > (From update of attachment 82105 [details] [details]) > > EFL EWS wasn't happy with this patch. > > Can someone else test the patch on his EFL machine? Strange if it works on one machine, but doesn't on the bot. There is no build error in other machine. EFLEWS has only build error. But, there was no build error when I built WebKit EFL with this patch in eflews machine. We are finding the reason. If this patch is landed to trunk, I think there is no problem. If there is build break, I will fix it as soon as possible.
In EFLEWS, there is no build error with this patch. (I stoped eflews, then built WebKit EFL with this patch.) Could you please review "+" this patch ? I will monitor the efl buildbot as soon as this patch is landed.
(In reply to comment #13) > In EFLEWS, there is no build error with this patch. (I stoped eflews, then built WebKit EFL with this patch.) > Could you please review "+" this patch ? > > I will monitor the efl buildbot as soon as this patch is landed. Ryuan, could you upload patch again ?
Created attachment 82883 [details] Patch
Comment on attachment 82883 [details] Patch ok
(In reply to comment #16) > (From update of attachment 82883 [details]) > ok Thank you for your review. I will see efl buildbot after landing this patch.
The commit-queue encountered the following flaky tests while processing attachment 82883 [details]: media/invalid-media-url-crash.html bug 51138 (author: inferno@chromium.org) The commit-queue is continuing to process your patch.
Comment on attachment 82883 [details] Patch Clearing flags on attachment: 82883 Committed r79069: <http://trac.webkit.org/changeset/79069>
All reviewed patches have been landed. Closing bug.