Bug 53861 - Replace FLT_MAX with std::numeric_limits
Summary: Replace FLT_MAX with std::numeric_limits
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-05 15:30 PST by Patrick R. Gansterer
Modified: 2011-02-06 10:44 PST (History)
2 users (show)

See Also:


Attachments
Patch (7.00 KB, patch)
2011-02-05 15:35 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (8.46 KB, patch)
2011-02-06 05:36 PST, Patrick R. Gansterer
kling: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch (8.47 KB, patch)
2011-02-06 09:23 PST, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-02-05 15:30:45 PST
see patch
Comment 1 Patrick R. Gansterer 2011-02-05 15:35:43 PST
Created attachment 81379 [details]
Patch
Comment 2 WebKit Review Bot 2011-02-05 18:52:27 PST
Attachment 81379 [details] did not build on mac:
Build output: http://queues.webkit.org/results/7701469
Comment 3 Patrick R. Gansterer 2011-02-06 05:36:12 PST
Created attachment 81399 [details]
Patch
Comment 4 Andreas Kling 2011-02-06 07:33:49 PST
Comment on attachment 81399 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=81399&action=review

r=me

> Source/WebCore/html/NumberInputType.cpp:-54
> -static const double numberDefaultMinimum = -FLT_MAX;
> -static const double numberDefaultMaximum = FLT_MAX;

This looked a little strange to me, but apparently it is intentional:
https://bugs.webkit.org/show_bug.cgi?id=48221 (just for reference)
Comment 5 WebKit Commit Bot 2011-02-06 08:29:16 PST
Comment on attachment 81399 [details]
Patch

Rejecting attachment 81399 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'build-..." exit_code: 2

Last 500 characters of output:
HTMLImageElement ..........
fast/dom/HTMLInputElement ...........
fast/dom/HTMLKeygenElement .
fast/dom/HTMLLabelElement ...
fast/dom/HTMLLabelElement/form .
fast/dom/HTMLLinkElement ...
fast/dom/HTMLMetaElement .
fast/dom/HTMLMeterElement ............
fast/dom/HTMLMeterElement/set-meter-properties.html -> failed

Exiting early after 1 failures. 7347 tests run.
154.30s total testing time

7346 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
4 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/7699743
Comment 6 Patrick R. Gansterer 2011-02-06 09:23:11 PST
Created attachment 81413 [details]
Patch
Comment 7 WebKit Commit Bot 2011-02-06 10:44:37 PST
Comment on attachment 81413 [details]
Patch

Clearing flags on attachment: 81413

Committed r77774: <http://trac.webkit.org/changeset/77774>
Comment 8 WebKit Commit Bot 2011-02-06 10:44:42 PST
All reviewed patches have been landed.  Closing bug.