Bug 53786 - check-webkit-style: The error message about NULL should be more clear for comments.
Summary: check-webkit-style: The error message about NULL should be more clear for com...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-04 10:17 PST by David Levin
Modified: 2011-02-09 11:54 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.55 KB, patch)
2011-02-04 10:22 PST, David Levin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2011-02-04 10:17:54 PST
There have been at least three bugs filed about this and probably other times people thought it was in error and didn't file a bug.
  https://bugs.webkit.org/show_bug.cgi?id=31215
  https://bugs.webkit.org/show_bug.cgi?id=34605
  https://bugs.webkit.org/show_bug.cgi?id=53755

This is my attempt to help clarify the issue.
Comment 1 David Levin 2011-02-04 10:22:13 PST
Created attachment 81243 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-02-04 13:25:01 PST
Comment on attachment 81243 [details]
Patch

What's "null"?
Comment 3 Eric Seidel (no email) 2011-02-04 13:25:23 PST
I support the "comments" thing, I'm not sure I understand the "null" bit.
Comment 4 David Levin 2011-02-04 13:33:46 PST
(In reply to comment #3)
> I support the "comments" thing, I'm not sure I understand the "null" bit.

I don't know if I get it either, but I going with what I've seen other say. For example, https://bugs.webkit.org/show_bug.cgi?id=34605#c2

And it appears in https://bugs.webkit.org/show_bug.cgi?id=53749 the patch author took the "null" route.
Comment 5 Eric Seidel (no email) 2011-02-04 13:39:16 PST
I see.  Using "null" in comments.  But "null" isn't a language primitive, or is it?  I can never remember.
Comment 6 David Levin 2011-02-04 13:43:28 PST
(In reply to comment #5)
> I see.  Using "null" in comments.  But "null" isn't a language primitive, or is it?  I can never remember.
No.

This particular line should only be printed for comments actually. The style checker has special logic to catch NULL in comments and people think it is a bug so I changed the text on this instance of the message to make it more clear.
Comment 7 Eric Seidel (no email) 2011-02-04 13:59:10 PST
Comment on attachment 81243 [details]
Patch

Oh.  OK.  it wasn't clear to me that tis' a comment-only message.
Comment 8 WebKit Commit Bot 2011-02-09 11:54:40 PST
Comment on attachment 81243 [details]
Patch

Clearing flags on attachment: 81243

Committed r78100: <http://trac.webkit.org/changeset/78100>
Comment 9 WebKit Commit Bot 2011-02-09 11:54:44 PST
All reviewed patches have been landed.  Closing bug.