WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
53755
check-webkit-style complains about the occurrence of "NULL" in comments
https://bugs.webkit.org/show_bug.cgi?id=53755
Summary
check-webkit-style complains about the occurrence of "NULL" in comments
Cosmin Truta
Reported
2011-02-03 21:11:06 PST
When preparing the fix for
bug 53749
, I noticed that check-webkit-style complains about the occurrence of "NULL", although this word is used (appropriately IMO) in a comment only. Is this behavior intentional, or is it a bug?
Attachments
Add attachment
proposed patch, testcase, etc.
David Levin
Comment 1
2011-02-04 09:44:32 PST
Intentional behavior and specifically coded this way in fact. The reasoning has been that NULL is not allowed in code so it doesn't make sense in comments. For example, in
bug 53749
, the comment says that a parameter may be NULL. That really isn't true because if code were to pass in NULL, it would be a style error. The parameter may be 0 in fact.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug