Bug 53755 - check-webkit-style complains about the occurrence of "NULL" in comments
Summary: check-webkit-style complains about the occurrence of "NULL" in comments
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-03 21:11 PST by Cosmin Truta
Modified: 2011-02-04 09:44 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cosmin Truta 2011-02-03 21:11:06 PST 
When preparing the fix for bug 53749, I noticed that check-webkit-style complains about the occurrence of "NULL", although this word is used (appropriately IMO) in a comment only.
Is this behavior intentional, or is it a bug?
Comment 1 David Levin 2011-02-04 09:44:32 PST 
Intentional behavior and specifically coded this way in fact.

The reasoning has been that NULL is not allowed in code so it doesn't make sense in comments. For example, in bug 53749, the comment says that a parameter may be NULL. That really isn't true because if code were to pass in NULL, it would be a style error. The parameter may be 0 in fact.