Bug 53420 - [Qt] PluginViewQt.cpp not compiling with ENABLE_NETSCAPE_PLUGIN_API=1
Summary: [Qt] PluginViewQt.cpp not compiling with ENABLE_NETSCAPE_PLUGIN_API=1
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 36702
  Show dependency tree / graph
 
Reported: 2011-01-31 05:49 PST by Oleg Romashin (:romaxa)
Modified: 2011-03-01 15:26 PST (History)
2 users (show)

See Also:

Attachments
Fix Qt Plugins compilation (1.81 KB, patch)
2011-01-31 11:58 PST, Oleg Romashin (:romaxa) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Romashin (:romaxa) 2011-01-31 05:49:11 PST 
Attempt to compile Webkit2 Qt with plugins enabled, it fails:
../../../WebCore/plugins/qt/PluginViewQt.cpp:69:24: error: qwebpage_p.h: No such file or directory
../../../WebCore/plugins/qt/PluginViewQt.cpp: In member function 'void WebCore::PluginView::updatePluginWidget()':
../../../WebCore/plugins/qt/PluginViewQt.cpp:167: error: 'QWebPagePrivate' has not been declared
../../../WebCore/plugins/qt/PluginViewQt.cpp: In function 'void WebCore::setXKeyEventSpecificFields(XEvent*, WebCore::KeyboardEvent*)':
../../../WebCore/plugins/qt/PluginViewQt.cpp:422: error: 'QWebPagePrivate' has not been declared

Sounds like it is not very good idea to use WebKit API's from WebCore module.

Change has been introduced in 
http://trac.webkit.org/changeset/61505
https://bugs.webkit.org/show_bug.cgi?id=36702
Comment 1 Oleg Romashin (:romaxa) 2011-01-31 05:55:23 PST 
Simon suggested to move "drtRun" into WebCore... but I'm not sure, because all other ports are doing exactly the same checks as Qt port, but not drtRun check. 

Interesting if bug 36702 was reproducible on Qt port only or on other platform also..
Comment 2 Oleg Romashin (:romaxa) 2011-01-31 11:58:26 PST 
Created attachment 80668 [details]
Fix Qt Plugins compilation

Not, sure if we can do that, but would be nice to know why it is needed in Qt port, and not in other ports like Gtk...
Comment 3 Robert Hogan 2011-01-31 12:09:52 PST 
(In reply to comment #2)
> Created an attachment (id=80668) [details]
> Fix Qt Plugins compilation
> 
> Not, sure if we can do that, but would be nice to know why it is needed in Qt port, and not in other ports like Gtk...

    // (ii) if we are running layout tests from DRT, paint() won't ever get called
    // so we need to call setNPWindowIfNeeded() if window geometry has changed
    if (!m_windowRect.intersects(frameView->frameRect())
        || (QWebPagePrivate::drtRun && platformPluginWidget() && (m_windowRect != oldWindowRect || m_clipRect != oldClipRect)))
        setNPWindowIfNeeded();

I believe Qt layout tests are run headless, Gtk tests are not.
Comment 4 Oleg Romashin (:romaxa) 2011-02-01 01:53:35 PST 
Comment on attachment 80668 [details]
Fix Qt Plugins compilation

Fail to apply
Comment 5 Oleg Romashin (:romaxa) 2011-03-01 15:26:15 PST 
Problem is not reproducible on webkit trunk