Bug 53420 – [Qt] PluginViewQt.cpp not compiling with ENABLE_NETSCAPE_PLUGIN_API=1

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: Plug-ins

[Oleg Romashin (:romaxa)]

Attempt to compile Webkit2 Qt with plugins enabled, it fails:
../../../WebCore/plugins/qt/PluginViewQt.cpp:69:24: error: qwebpage_p.h: No such file or directory
../../../WebCore/plugins/qt/PluginViewQt.cpp: In member function 'void WebCore::PluginView::updatePluginWidget()':
../../../WebCore/plugins/qt/PluginViewQt.cpp:167: error: 'QWebPagePrivate' has not been declared
../../../WebCore/plugins/qt/PluginViewQt.cpp: In function 'void WebCore::setXKeyEventSpecificFields(XEvent*, WebCore::KeyboardEvent*)':
../../../WebCore/plugins/qt/PluginViewQt.cpp:422: error: 'QWebPagePrivate' has not been declared

Sounds like it is not very good idea to use WebKit API's from WebCore module.

Change has been introduced in 
http://trac.webkit.org/changeset/61505
https://bugs.webkit.org/show_bug.cgi?id=36702

[Oleg Romashin (:romaxa)]

Simon suggested to move "drtRun" into WebCore... but I'm not sure, because all other ports are doing exactly the same checks as Qt port, but not drtRun check. 

Interesting if bug 36702 was reproducible on Qt port only or on other platform also..

[Oleg Romashin (:romaxa)]

Created attachment 80668 [details]
Fix Qt Plugins compilation

Not, sure if we can do that, but would be nice to know why it is needed in Qt port, and not in other ports like Gtk...

[Robert Hogan]

(In reply to comment #2)
> Created an attachment (id=80668) [details]
> Fix Qt Plugins compilation
> 
> Not, sure if we can do that, but would be nice to know why it is needed in Qt port, and not in other ports like Gtk...

    // (ii) if we are running layout tests from DRT, paint() won't ever get called
    // so we need to call setNPWindowIfNeeded() if window geometry has changed
    if (!m_windowRect.intersects(frameView->frameRect())
        || (QWebPagePrivate::drtRun && platformPluginWidget() && (m_windowRect != oldWindowRect || m_clipRect != oldClipRect)))
        setNPWindowIfNeeded();

I believe Qt layout tests are run headless, Gtk tests are not.

[Oleg Romashin (:romaxa)]

Comment on attachment 80668 [details]
Fix Qt Plugins compilation

Fail to apply

[Oleg Romashin (:romaxa)]

Problem is not reproducible on webkit trunk