Bug 53184 - Allow inter-ideograph justification for CJK
Summary: Allow inter-ideograph justification for CJK
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-01-26 11:58 PST by mitz
Modified: 2019-12-16 19:48 PST (History)
5 users (show)

See Also:

Attachments
Cross-platform and Mac parts (503.44 KB, patch)
2011-01-26 12:04 PST, mitz 		no flags Details | Formatted Diff | Diff
Cross-platform and Mac parts (512.49 KB, patch)
2011-01-26 13:11 PST, mitz 		no flags Details | Formatted Diff | Diff
Cross-platform and Mac parts (512.97 KB, patch)
2011-01-26 13:41 PST, mitz 		no flags Details | Formatted Diff | Diff
Cross-platform and Mac parts (512.98 KB, patch)
2011-01-26 14:05 PST, mitz 		hyatt: review+
Details | Formatted Diff | Diff
Cross-platform and Mac parts (deleted)
2011-01-26 16:06 PST, mitz 		no flags Details
Patch with build fixes and vertical-rl test (771.65 KB, patch)
2011-01-26 16:50 PST, mitz 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2011-01-26 11:58:38 PST 
<rdar://problem/8446709>
Comment 1 mitz 2011-01-26 12:04:20 PST 
Created attachment 80217 [details]
Cross-platform and Mac parts
Comment 2 WebKit Review Bot 2011-01-26 12:30:53 PST 
Attachment 80217 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7556341
Comment 3 Build Bot 2011-01-26 12:41:15 PST 
Attachment 80217 [details] did not build on win:
Build output: http://queues.webkit.org/results/7535314
Comment 4 mitz 2011-01-26 13:11:39 PST 
Created attachment 80226 [details]
Cross-platform and Mac parts
Comment 5 Early Warning System Bot 2011-01-26 13:15:40 PST 
Attachment 80217 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7586309
Comment 6 WebKit Review Bot 2011-01-26 13:31:21 PST 
Attachment 80226 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7591358
Comment 7 mitz 2011-01-26 13:41:32 PST 
Created attachment 80227 [details]
Cross-platform and Mac parts
Comment 8 Build Bot 2011-01-26 13:47:33 PST 
Attachment 80226 [details] did not build on win:
Build output: http://queues.webkit.org/results/7581343
Comment 9 WebKit Review Bot 2011-01-26 13:55:28 PST 
Attachment 80227 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7534383
Comment 10 mitz 2011-01-26 14:05:39 PST 
Created attachment 80233 [details]
Cross-platform and Mac parts
Comment 11 Build Bot 2011-01-26 14:23:05 PST 
Attachment 80227 [details] did not build on win:
Build output: http://queues.webkit.org/results/7493363
Comment 12 WebKit Review Bot 2011-01-26 14:24:49 PST 
Attachment 80217 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7596334
Comment 13 Dave Hyatt 2011-01-26 14:50:38 PST 
Comment on attachment 80233 [details]
Cross-platform and Mac parts

I know it runs the same code path, but a vertical-rl test would be nice here as well, and it would be easy to add.  r=me
Comment 14 WebKit Review Bot 2011-01-26 15:07:56 PST 
Attachment 80233 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7627335
Comment 15 Build Bot 2011-01-26 15:09:38 PST 
Attachment 80233 [details] did not build on win:
Build output: http://queues.webkit.org/results/7593330
Comment 16 mitz 2011-01-26 16:06:26 PST 
Created attachment 80255 [details]
Cross-platform and Mac parts

Build fix edition
Comment 17 mitz 2011-01-26 16:10:56 PST 
Comment on attachment 80255 [details]
Cross-platform and Mac parts

Marking r? to get this building on the bots.
Comment 18 William Siegrist 2011-01-26 16:38:57 PST 
The content of attachment 80255 [details] has been deleted by
    William Siegrist <wsiegrist@apple.com>
who provided the following reason:

Deleted by request of mitzpettel

The token used to delete this attachment was generated at 2011-01-26 16:38:33 PST.
Comment 19 mitz 2011-01-26 16:50:18 PST 
Created attachment 80266 [details]
Patch with build fixes and vertical-rl test
Comment 20 mitz 2011-01-26 17:40:41 PST 
Committed r76743.
<http://trac.webkit.org/changeset/76743>