Bug 205321 - [cairo] text-align:justify layouts texts wrongly for complex texts
Summary: [cairo] text-align:justify layouts texts wrongly for complex texts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-16 19:27 PST by Fujii Hironori
Modified: 2019-12-17 18:20 PST (History)
6 users (show)

See Also:

Attachments
justify-ideograph-complex-actual.png (177.13 KB, image/png)
2019-12-16 19:28 PST, Fujii Hironori 		no flags Details
Patch (1.22 MB, patch)
2019-12-16 20:19 PST, Fujii Hironori 		cgarcia: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2019-12-16 19:27:04 PST 
In Source/WebCore/platform/graphics/cairo/FontCairoHarfbuzzNG.cpp, canExpandAroundIdeographsInComplexText return false.

> bool FontCascade::canExpandAroundIdeographsInComplexText()
> {
>     return false;
> }

However, ComplexTextController doesn't take it into account.

fast/text/justify-ideograph-complex.html is a test case.
Comment 1 Fujii Hironori 2019-12-16 19:28:28 PST 
Created attachment 385847 [details]
justify-ideograph-complex-actual.png
Comment 2 Fujii Hironori 2019-12-16 19:49:18 PST 
The tests and code have come from Bug 53184.
Comment 3 Fujii Hironori 2019-12-16 20:19:43 PST 
Created attachment 385849 [details]
Patch
Comment 4 Carlos Garcia Campos 2019-12-17 00:50:56 PST 
Comment on attachment 385849 [details]
Patch

Thanks!
Comment 5 Fujii Hironori 2019-12-17 18:19:07 PST 
Committed r253664: <https://trac.webkit.org/changeset/253664>
Comment 6 Radar WebKit Bug Importer 2019-12-17 18:20:35 PST 
<rdar://problem/58029006>