This will make the source less confusing
Created attachment 79981 [details] Patch
Sounds sane to me.
Comment on attachment 79981 [details] Patch rs=me. You should definitely wait for the EWS bots to pass.
Attachment 79981 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7608329
For GTK+, you also need to change the AM_CONDITIONAL line in configure.ac in the root directory of the repository.
FYI, http://codereview.chromium.org/6256013 is being landed in Chromium to prevent an interruption in WebGL support when this change lands.
Created attachment 79985 [details] Patch
Comment on attachment 79985 [details] Patch rs=me. (Again please let the ews chew this through.)
(In reply to comment #8) > (From update of attachment 79985 [details]) > rs=me. (Again please let the ews chew this through.) Will do. Hopefully I've fixed the GTK problem. I think the other two that didn't run on the first one will pass. But we'll see
Committed r76600: <http://trac.webkit.org/changeset/76600>
Committed r76601: <http://trac.webkit.org/changeset/76601>
Seems like update-webkit failed to correctly merge the change log, and my patch ended up in the wrong bug. Should be placed in bug 52338
http://trac.webkit.org/changeset/76600 might have broken GTK Linux 64-bit Debug
http://trac.webkit.org/changeset/76601 might have broken GTK Linux 64-bit Debug
Created attachment 80571 [details] Fix build-webkit to use ENABLE_WEBGL Tools/Scripts/build-webkit needs to change ENABLE_3D_CANVAS to ENABLE_WEBGL.
Comment on attachment 80571 [details] Fix build-webkit to use ENABLE_WEBGL Could you please regenerate this patch using the prepare-ChangeLog and svn-create-patch scripts described in http://webkit.org/coding/contributing.html ? It might also be helpful to file a new bug report and point it at this one, just so the dependency chain can be tracked.
Created attachment 80641 [details] Fix build-webkit to use ENABLE_WEBGL regenerate patch using prepare-ChangeLog and svn-create-patch scripts
Comment on attachment 80641 [details] Fix build-webkit to use ENABLE_WEBGL Looks okay to me. Let's let the commit queue process it.
(In reply to comment #18) > Looks okay to me. Let's let the commit queue process it. I still don't see this patch in the queue - maybe it won't queue it because this bug is closed?
(In reply to comment #19) > (In reply to comment #18) > > Looks okay to me. Let's let the commit queue process it. > > I still don't see this patch in the queue - maybe it won't queue it because this bug is closed? It's possible. Would you please file a new bug and regenerate the patch against it? It will make tracking this change easier.
(In reply to comment #20) > It's possible. Would you please file a new bug and regenerate the patch against it? It will make tracking this change easier. Created bug 53714
The queue does not process patches on closed bugs. You could re-open the bug and the queue would see it though.
(In reply to comment #22) > The queue does not process patches on closed bugs. You could re-open the bug and the queue would see it though. Thanks, I didn't know that. I think it would be best to apply the patch under the new bug and will review it shortly.
Comment on attachment 80641 [details] Fix build-webkit to use ENABLE_WEBGL Will review the patch on the new bug.