TransformationMatrix multiply operations apply operands in wrong order.
Created attachment 79547 [details]
Attachment 79547 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7578232
Attachment 79547 [details] did not build on qt:
Build output: http://queues.webkit.org/results/7515234
Created attachment 79686 [details]
Comment on attachment 79686 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=79686&action=review
r=me with a bit more detail in the Changelog.
Could you be a bit more specific about the change? You're fixing a very confusing part of the code and think you're doing two things. One is flipping the order used to combine matrix, the other is changing multLeft to multiply. This is really doing 2 things: it fixes the incorrect naming of the function being called implicitly flipping the order of the operation. All that gets buried in the name change, so if you could add another sentence or two here, it would make it more clear to future coders.
> +// the array refers to the column that the element lies in; the second the row.
This last sentence is awkward. either say "the second, the row", or better "the second index refers to the row"
Created attachment 79882 [details]
The commit-queue encountered the following flaky tests while processing attachment 79882 [details]:
animations/dynamic-stylesheet-loading.html bug 52669 (author: firstname.lastname@example.org)
The commit-queue is continuing to process your patch.
Comment on attachment 79882 [details]
Clearing flags on attachment: 79882
Committed r76537: <http://trac.webkit.org/changeset/76537>
All reviewed patches have been landed. Closing bug.