Bug 52748 - nrwt: convert port/* modules to using the filesystem wrappers
Summary: nrwt: convert port/* modules to using the filesystem wrappers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks: 52753
  Show dependency tree / graph
 
Reported: 2011-01-19 14:40 PST by Dirk Pranke
Modified: 2011-01-19 17:49 PST (History)
4 users (show)

See Also:

Attachments
Patch (22.36 KB, patch)
2011-01-19 14:40 PST, Dirk Pranke 		no flags Details | Formatted Diff | Diff
Patch (22.42 KB, patch)
2011-01-19 14:42 PST, Dirk Pranke 		no flags Details | Formatted Diff | Diff
fix MockFileSystem.read_text_file() to raise KeyError if we don't know the file, fix isdir() to be thread-safe (23.03 KB, patch)
2011-01-19 14:51 PST, Dirk Pranke 		no flags Details | Formatted Diff | Diff
keep a copy of the file list; using a list comprehension didn't work (23.03 KB, patch)
2011-01-19 15:14 PST, Dirk Pranke 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-01-19 14:40:18 PST 
nrwt: convert port/* modules to using the filesystem wrappers
Comment 1 Dirk Pranke 2011-01-19 14:40:36 PST 
Created attachment 79488 [details]
Patch
Comment 2 Dirk Pranke 2011-01-19 14:42:02 PST 
Created attachment 79489 [details]
Patch
Comment 3 Dirk Pranke 2011-01-19 14:51:59 PST 
Created attachment 79492 [details]
fix MockFileSystem.read_text_file() to raise KeyError if we don't know the file, fix isdir() to be thread-safe
Comment 4 Dirk Pranke 2011-01-19 15:14:25 PST 
Created attachment 79499 [details]
keep a copy of the file list; using a list comprehension didn't work
Comment 5 Dirk Pranke 2011-01-19 17:49:27 PST 
Comment on attachment 79499 [details]
keep a copy of the file list; using a list comprehension didn't work

Clearing flags on attachment: 79499

Committed r76184: <http://trac.webkit.org/changeset/76184>
Comment 6 Dirk Pranke 2011-01-19 17:49:32 PST 
All reviewed patches have been landed.  Closing bug.