Bug 52705 - [Qt] GraphicsContext::strokePath() paints solid shadows with incorrect alpha
: [Qt] GraphicsContext::strokePath() paints solid shadows with incorrect alpha
Status: RESOLVED FIXED
: WebKit
Canvas
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-01-19 02:06 PST by
Modified: 2011-01-19 21:58 PST (History)


Attachments
Patch (19.57 KB, patch)
2011-01-19 02:09 PST, Helder Correia
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-01-19 02:06:37 PST
This is related to bug 52611. The shadow color alpha must be multiplied by the context pen alpha. Fixing this results in correct behavior for Canvas path stroke() and strokeRect() [which relies on stroke()].
------- Comment #1 From 2011-01-19 02:09:37 PST -------
Created an attachment (id=79402) [details]
Patch
------- Comment #2 From 2011-01-19 13:43:32 PST -------
(From update of attachment 79402 [details])
r=me, let's hope nobody else chokes on the test :)
------- Comment #3 From 2011-01-19 21:57:00 PST -------
The commit-queue encountered the following flaky tests while processing attachment 79402 [details]:

fast/spatial-navigation/snav-iframe-flattening-simple.html bug 52783 (author: tonikitoo@webkit.org)
The commit-queue is continuing to process your patch.
------- Comment #4 From 2011-01-19 21:57:59 PST -------
(From update of attachment 79402 [details])
Clearing flags on attachment: 79402

Committed r76206: <http://trac.webkit.org/changeset/76206>
------- Comment #5 From 2011-01-19 21:58:05 PST -------
All reviewed patches have been landed.  Closing bug.