Bug 52485 – make line selection have a extend only from where you start the selection in the code review tool

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ojan Vafai]

make line selection have a extend only from where you start the selection in the code review tool

[Ojan Vafai]

Created attachment 79012 [details]
Patch

[Ojan Vafai]

As requested in bug 52462.

[Adam Barth]

Comment on attachment 79012 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79012&action=review

This code reads very nicely with all these helper functions to convert between representations.

> Websites/bugs.webkit.org/code-review.js:1067
> +    while (current_index <= last_index) {
> +      $('#line' + current_index).addClass('selected')
> +      current_index++;
> +    }

This looks like it could get expensive with a large selection.  Have you tested a large selection?

[Ojan Vafai]

(In reply to comment #3)
> (From update of attachment 79012 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=79012&action=review
> 
> > Websites/bugs.webkit.org/code-review.js:1067
> > +    while (current_index <= last_index) {
> > +      $('#line' + current_index).addClass('selected')
> > +      current_index++;
> > +    }
> 
> This looks like it could get expensive with a large selection.  Have you tested a large selection?

There's only so large of a selection you can make given that we don't scroll. You can get at most 1 screenful of lines. In other words, you can't make a large selection.

[Ojan Vafai]

Ping.

[Adam Barth]

Comment on attachment 79012 [details]
Patch

Oops.  Sorry.

[Ojan Vafai]

Committed r76268: <http://trac.webkit.org/changeset/76268>