Bug 52462 – tweak line selection in code review tool

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ojan Vafai]

tweak line selection in code review tool

[Ojan Vafai]

Created attachment 78970 [details]
Patch

[Adam Barth]

Comment on attachment 78970 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78970&action=review

I'm not sure I quite follow 100%, but this looks fine.

> Websites/bugs.webkit.org/ChangeLog:14
> +        -Make it so that if you click on the line immediately above
> +        a line that has a comment it will add a new comment instead of
> +        adding lines to the following comment. If the last selected line
> +        overlaps existing comment lines though they will still get
> +        added to the existing comment.

Interesting.  That's a nice refinement.  One thing I'd like to do better is if you drag select a bunch of lines and then move your mouse backwards, you should "unselect" some lines.  Currently, once selected, there is no unselect.

[Ojan Vafai]

(In reply to comment #2)
> (From update of attachment 78970 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=78970&action=review
> Interesting.  That's a nice refinement.  One thing I'd like to do better is if you drag select a bunch of lines and then move your mouse backwards, you should "unselect" some lines.  Currently, once selected, there is no unselect.

Oh. I thought that was by design. I'd be happy to fix this.

[Ojan Vafai]

Committed r75816: <http://trac.webkit.org/changeset/75816>