Bug 52481 – Stop instantiating legacy editing positions in AccessibilityRenderObject.cpp, Element.cpp, BreakBlockquoteCommand.cpp, CompositeEditCommand.cpp, and DeleteButtonController.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Ryosuke Niwa]

This is a cleanup bug.

[Ryosuke Niwa]

Created attachment 79004 [details]
cleanup

[Eric Seidel (no email)]

Comment on attachment 79004 [details]
cleanup

OK.

[Eric Seidel (no email)]

We're going to have to solve the Position ref-churn problem at some point.  All these functions should be reutrning some sort of PassPosition object which knows how to avoid the ref-churn.

[Ryosuke Niwa]

(In reply to comment #3)
> We're going to have to solve the Position ref-churn problem at some point.  All these functions should be reutrning some sort of PassPosition object which knows how to avoid the ref-churn.

Yeah, that'll be nice.  In fact, PassPosition can just contain Node* and offset because we shouldn't be relying on positions to hang onto nodes given Position's constructor takes Node*.

[Ryosuke Niwa]

Comment on attachment 79004 [details]
cleanup

Clearing flags on attachment: 79004

Committed r75835: <http://trac.webkit.org/changeset/75835>

[Ryosuke Niwa]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

(In reply to comment #4)
> PassPosition can just contain Node* and offset because we shouldn't be relying on positions to hang onto nodes given Position's constructor takes Node*.

That’t not right. I think PassPosition needs to contain a RefPtr or PassRefPtr.

[Ryosuke Niwa]

(In reply to comment #7)
> (In reply to comment #4)
> > PassPosition can just contain Node* and offset because we shouldn't be relying on positions to hang onto nodes given Position's constructor takes Node*.
> 
> That’t not right. I think PassPosition needs to contain a RefPtr or PassRefPtr.

Yeah, it would have worked if only Position's helper functions (which also take Node*) returned PassPosition but to allow other functions return PassPosition, we need to use PassRefPtr (my work-in-progress patch uses PassRefPtr).  Anyhow, PassPosition is to be implemented in the bug 52504.