Bug 52474 - Volume slider for audio element does not fully display in Qt
Summary: Volume slider for audio element does not fully display in Qt
Status: RESOLVED DUPLICATE of bug 52822
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-14 13:17 PST by Keith Rosenblatt
Modified: 2011-01-21 11:52 PST (History)
3 users (show)

See Also:


Attachments
Fix to Qt media control CSS (24.70 KB, patch)
2011-01-18 11:39 PST, Keith Rosenblatt
no flags Details | Formatted Diff | Diff
Fix to Qt media control CSS (5.28 KB, patch)
2011-01-19 10:37 PST, Keith Rosenblatt
laszlo.gombos: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rosenblatt 2011-01-14 13:17:46 PST
Overview: 

    The volume slider, upon hovering over the mute button of an audio element, is not fully visible.  The portion that displays beyond the controls panel is hidden.

Steps to Reproduce: 

    1) View html page with an audio element in QtTestBrowser
    2) move cursor over mute button
    3) view volume bar that appears

Actual Results: 

    Only very bottom of volume bar is visible

Expected Results: 

    Entire volume slider should be visible.

Build Date & Platform: 

    Build 2011-01-14 on Linux with Qt 4.7.0
Comment 1 Keith Rosenblatt 2011-01-18 11:39:19 PST
Created attachment 79301 [details]
Fix to Qt media control CSS
Comment 2 Keith Rosenblatt 2011-01-19 10:37:21 PST
Created attachment 79446 [details]
Fix to Qt media control CSS

Drop unnecessary pixel test
Comment 3 Antonio Gomes 2011-01-19 11:25:10 PST
Comment on attachment 79446 [details]
Fix to Qt media control CSS

The test lacks expected results for platforms other than Qt.
Comment 4 Laszlo Gombos 2011-01-19 20:30:23 PST
Comment on attachment 79446 [details]
Fix to Qt media control CSS

r- to fix expected results for other ports. An entry in the Skipped lists with a comment will do it.
Comment 5 Antonio Gomes 2011-01-21 06:35:52 PST
(In reply to comment #4)
> (From update of attachment 79446 [details])
> r- to fix expected results for other ports. An entry in the Skipped lists with a comment will do it.

I am afraid skipping the test for other can not be ideal, since this is changing default .css files.

-    overflow: hidden;
+    overflow: visible;
     height: 100%;

I would suggest at least also checking in Mac expected files...
Comment 6 Antonio Gomes 2011-01-21 11:07:14 PST
I am afraid skipping the test for other can not be ideal, since this is changing default .css files.
> I would suggest at least also checking in Mac expected files...

Correcting myself, the file being changed is Qt-only, so no worries.

Another option is adding the test to LayoutTest/platform/qt/xxx/yyy , so it will only run on QtWebKit, and does not need to be skipped to others.

Up to you ...
Comment 7 Keith Rosenblatt 2011-01-21 11:49:30 PST
Comment on attachment 79446 [details]
Fix to Qt media control CSS

Obsoleted by https://bugs.webkit.org/show_bug.cgi?id=52822
Comment 8 Keith Rosenblatt 2011-01-21 11:52:55 PST

*** This bug has been marked as a duplicate of bug 52822 ***