Bug 51700 - [Qt] On Linux build of TestNetscapePlugin fails if gold linker is used
Summary: [Qt] On Linux build of TestNetscapePlugin fails if gold linker is used
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-29 01:45 PST by Konstantin Tokarev
Modified: 2011-01-05 13:25 PST (History)
5 users (show)

See Also:

Attachments
Link libX11 explicitly on unix (1.59 KB, patch)
2010-12-29 01:48 PST, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2010-12-29 01:45:28 PST 
TestNetscapePlugin explicitly uses X11 functions but is not linked with libX11, and gold does not perform transitive linking
Attached patch fixes the problem
Comment 1 Konstantin Tokarev 2010-12-29 01:48:52 PST 
Created attachment 77607 [details]
Link libX11 explicitly on unix
Comment 2 Eric Seidel (no email) 2010-12-29 18:30:56 PST 
Comment on attachment 77607 [details]
Link libX11 explicitly on unix

OK.
Comment 3 WebKit Commit Bot 2010-12-29 19:16:03 PST 
The commit-queue encountered the following flaky tests while processing attachment 77607 [details]:

http/tests/xmlhttprequest/cross-origin-no-authorization.html bug 51732 (author: ap@webkit.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2010-12-29 19:17:11 PST 
Comment on attachment 77607 [details]
Link libX11 explicitly on unix

Clearing flags on attachment: 77607

Committed r74776: <http://trac.webkit.org/changeset/74776>
Comment 5 WebKit Commit Bot 2010-12-29 19:17:18 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Jan Erik Hanssen 2011-01-05 13:25:18 PST 
(In reply to comment #1)
> Created an attachment (id=77607) [details]
> Link libX11 explicitly on unix

This broke linking of the Qt port on OS X, see bug 51948.