Bug 51535 – [GTK] Show current time / total in media player

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

Current media player doesn't show information about the current and total time.

[Carlos Garcia Campos]

Created attachment 77330 [details]
Patch to show current time/total in media player

[Xan Lopez]

Comment on attachment 77330 [details]
Patch to show current time/total in media player

View in context: https://bugs.webkit.org/attachment.cgi?id=77330&action=review

> WebCore/css/mediaControlsGtk.css:63
> +

As a bikeshed comment I'd say hardcoding stuff in pixels in our css files is less than ideal, but I see we are already doing it everywhere.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 77330 [details]:

fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 77330 [details]
Patch to show current time/total in media player

Clearing flags on attachment: 77330

Committed r74643: <http://trac.webkit.org/changeset/74643>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 77330 [details]:

http/tests/xmlhttprequest/open-async-overload.html bug 51594 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Review Bot]

http://trac.webkit.org/changeset/74643 might have broken GTK Linux 32-bit Release