Bug 51535 - [GTK] Show current time / total in media player
Summary: [GTK] Show current time / total in media player
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-23 06:06 PST by Carlos Garcia Campos
Modified: 2010-12-24 12:40 PST (History)
5 users (show)

See Also:


Attachments
Patch to show current time/total in media player (3.43 KB, patch)
2010-12-23 06:08 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2010-12-23 06:06:03 PST
Current media player doesn't show information about the current and total time.
Comment 1 Carlos Garcia Campos 2010-12-23 06:08:00 PST
Created attachment 77330 [details]
Patch to show current time/total in media player
Comment 2 Xan Lopez 2010-12-24 09:27:00 PST
Comment on attachment 77330 [details]
Patch to show current time/total in media player

View in context: https://bugs.webkit.org/attachment.cgi?id=77330&action=review

> WebCore/css/mediaControlsGtk.css:63
> +

As a bikeshed comment I'd say hardcoding stuff in pixels in our css files is less than ideal, but I see we are already doing it everywhere.
Comment 3 WebKit Commit Bot 2010-12-24 10:58:24 PST
The commit-queue encountered the following flaky tests while processing attachment 77330 [details]:

fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2010-12-24 11:02:42 PST
Comment on attachment 77330 [details]
Patch to show current time/total in media player

Clearing flags on attachment: 77330

Committed r74643: <http://trac.webkit.org/changeset/74643>
Comment 5 WebKit Commit Bot 2010-12-24 11:02:46 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Commit Bot 2010-12-24 11:11:33 PST
The commit-queue encountered the following flaky tests while processing attachment 77330 [details]:

http/tests/xmlhttprequest/open-async-overload.html bug 51594 (author: morrita@google.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Review Bot 2010-12-24 12:40:16 PST
http://trac.webkit.org/changeset/74643 might have broken GTK Linux 32-bit Release