Bug 51408 – matrix3d() must take the zoom factor into account

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Ariya Hidayat]

Similar like https://bugs.webkit.org/show_bug.cgi?id=49774.

[Jan Erik Hanssen]

Created attachment 77166 [details]
Patch

[WebKit Review Bot]

Attachment 77166 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/transforms/matrix-with-zoom-3d-expected.checksum', u'LayoutTests/fast/transforms/matrix-with-zoom-3d-expected.png', u'LayoutTests/fast/transforms/matrix-with-zoom-3d-expected.txt', u'LayoutTests/fast/transforms/matrix-with-zoom-3d.html', u'WebCore/ChangeLog', u'WebCore/css/CSSStyleSelector.cpp']" exit_code: 1
WebCore/css/CSSStyleSelector.cpp:6844:  static_cast is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/css/CSSStyleSelector.cpp:6845:  static_cast is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jan Erik Hanssen]

(In reply to comment #2)
> Attachment 77166 [details] did not pass style-queue:

This seems to be bogus, static_cast is obviously not an identifier name.

[Simon Fraser (smfr)]

Comment on attachment 77166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77166&action=review

> WebCore/ChangeLog:8
> +        Test: fast/transforms/matrix-with-zoom-3d.html

The test should go into transforms/3d.

[Jan Erik Hanssen]

Created attachment 77172 [details]
Patch

Change the test directory

[WebKit Review Bot]

Attachment 77172 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/transforms/3d/general/matrix-with-zoom-3d-expected.checksum', u'LayoutTests/transforms/3d/general/matrix-with-zoom-3d-expected.png', u'LayoutTests/transforms/3d/general/matrix-with-zoom-3d-expected.txt', u'LayoutTests/transforms/3d/general/matrix-with-zoom-3d.html', u'WebCore/ChangeLog', u'WebCore/css/CSSStyleSelector.cpp']" exit_code: 1
WebCore/css/CSSStyleSelector.cpp:6844:  static_cast is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/css/CSSStyleSelector.cpp:6845:  static_cast is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ariya Hidayat]

Comment on attachment 77172 [details]
Patch

Clearing flags on attachment: 77172

Committed r74451: <http://trac.webkit.org/changeset/74451>

[Ariya Hidayat]

All reviewed patches have been landed.  Closing bug.