Bug 51408 - matrix3d() must take the zoom factor into account
Summary: matrix3d() must take the zoom factor into account
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Ariya Hidayat
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-21 11:12 PST by Ariya Hidayat
Modified: 2010-12-21 19:43 PST (History)
4 users (show)

See Also:

Attachments
Patch (8.26 KB, patch)
2010-12-21 16:51 PST, Jan Erik Hanssen 		no flags Details | Formatted Diff | Diff
Patch (8.36 KB, patch)
2010-12-21 17:51 PST, Jan Erik Hanssen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ariya Hidayat 2010-12-21 11:12:59 PST 
Similar like https://bugs.webkit.org/show_bug.cgi?id=49774.
Comment 1 Jan Erik Hanssen 2010-12-21 16:51:59 PST 
Created attachment 77166 [details]
Patch
Comment 2 WebKit Review Bot 2010-12-21 16:56:41 PST 
Attachment 77166 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/transforms/matrix-with-zoom-3d-expected.checksum', u'LayoutTests/fast/transforms/matrix-with-zoom-3d-expected.png', u'LayoutTests/fast/transforms/matrix-with-zoom-3d-expected.txt', u'LayoutTests/fast/transforms/matrix-with-zoom-3d.html', u'WebCore/ChangeLog', u'WebCore/css/CSSStyleSelector.cpp']" exit_code: 1
WebCore/css/CSSStyleSelector.cpp:6844:  static_cast is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/css/CSSStyleSelector.cpp:6845:  static_cast is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Jan Erik Hanssen 2010-12-21 16:59:52 PST 
(In reply to comment #2)
> Attachment 77166 [details] did not pass style-queue:

This seems to be bogus, static_cast is obviously not an identifier name.
Comment 4 Simon Fraser (smfr) 2010-12-21 17:29:12 PST 
Comment on attachment 77166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=77166&action=review

> WebCore/ChangeLog:8
> +        Test: fast/transforms/matrix-with-zoom-3d.html

The test should go into transforms/3d.
Comment 5 Jan Erik Hanssen 2010-12-21 17:51:44 PST 
Created attachment 77172 [details]
Patch

Change the test directory
Comment 6 WebKit Review Bot 2010-12-21 17:54:49 PST 
Attachment 77172 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/transforms/3d/general/matrix-with-zoom-3d-expected.checksum', u'LayoutTests/transforms/3d/general/matrix-with-zoom-3d-expected.png', u'LayoutTests/transforms/3d/general/matrix-with-zoom-3d-expected.txt', u'LayoutTests/transforms/3d/general/matrix-with-zoom-3d.html', u'WebCore/ChangeLog', u'WebCore/css/CSSStyleSelector.cpp']" exit_code: 1
WebCore/css/CSSStyleSelector.cpp:6844:  static_cast is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/css/CSSStyleSelector.cpp:6845:  static_cast is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Ariya Hidayat 2010-12-21 19:42:53 PST 
Comment on attachment 77172 [details]
Patch

Clearing flags on attachment: 77172

Committed r74451: <http://trac.webkit.org/changeset/74451>
Comment 8 Ariya Hidayat 2010-12-21 19:43:00 PST 
All reviewed patches have been landed.  Closing bug.