Bug 49774 - Need to scale translation values in matrix() by the zoom factor.
Summary: Need to scale translation values in matrix() by the zoom factor.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-18 17:30 PST by Simon Fraser (smfr)
Modified: 2010-12-21 15:26 PST (History)
2 users (show)

See Also:


Attachments
Testcase (537 bytes, text/html)
2010-11-18 17:30 PST, Simon Fraser (smfr)
no flags Details
WebCore: (5.16 KB, patch)
2010-12-20 23:51 PST, Ariya Hidayat
no flags Details | Formatted Diff | Diff
https://bugs.webkit.org/show_bug.cgi?id=49774 (7.82 KB, patch)
2010-12-21 12:38 PST, Ariya Hidayat
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2010-11-18 17:30:32 PST
Created attachment 74328 [details]
Testcase

Need to scale translation values in matrix() by the zoom factor.
Comment 1 Ariya Hidayat 2010-12-20 23:51:29 PST
Created attachment 77088 [details]
WebCore:
Comment 2 Simon Fraser (smfr) 2010-12-21 09:04:13 PST
Comment on attachment 77088 [details]
WebCore:

View in context: https://bugs.webkit.org/attachment.cgi?id=77088&action=review

r=me. I think we'll have to fix matrix3d() as well; can you file a new bug on that?

> LayoutTests/fast/transforms/matrix-with-zoom.html:49
> +        resultString += "PASS - Element " + id1 + " and Element " + id2 + " had identical position<br>";
> +    } else {
> +        resultString += "FAIL - Element " + id1 + " and Element " + id2 + " had different position<br>";

"positions"

> LayoutTests/fast/transforms/matrix-with-zoom.html:63
> +<p>You should see green box only. If you see red, the test has failed.</p>

I don't think it's useful to have this text in a pixel test.
Comment 3 Ariya Hidayat 2010-12-21 11:14:50 PST
> r=me. I think we'll have to fix matrix3d() as well; can you file a new bug on that?

Good point. https://bugs.webkit.org/show_bug.cgi?id=51408

> > LayoutTests/fast/transforms/matrix-with-zoom.html:63
> > +<p>You should see green box only. If you see red, the test has failed.</p>
> 
> I don't think it's useful to have this text in a pixel test.

It's useful when running the test from a web browser (I just followed other similar tests).

The patch is also missing a pixel test.
Comment 4 Ariya Hidayat 2010-12-21 12:06:56 PST
Comment on attachment 77088 [details]
WebCore:

Clearing the review flag. Will update a new one.
Comment 6 Ariya Hidayat 2010-12-21 15:26:35 PST
Comment on attachment 77143 [details]
https://bugs.webkit.org/show_bug.cgi?id=49774

Clearing flags on attachment: 77143

Committed r74430: <http://trac.webkit.org/changeset/74430>
Comment 7 Ariya Hidayat 2010-12-21 15:26:42 PST
All reviewed patches have been landed.  Closing bug.