Bug 49774 – Need to scale translation values in matrix() by the zoom factor.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Simon Fraser (smfr)]

Created attachment 74328 [details]
Testcase

Need to scale translation values in matrix() by the zoom factor.

[Ariya Hidayat]

Created attachment 77088 [details]
WebCore:

[Simon Fraser (smfr)]

Comment on attachment 77088 [details]
WebCore:

View in context: https://bugs.webkit.org/attachment.cgi?id=77088&action=review

r=me. I think we'll have to fix matrix3d() as well; can you file a new bug on that?

> LayoutTests/fast/transforms/matrix-with-zoom.html:49
> +        resultString += "PASS - Element " + id1 + " and Element " + id2 + " had identical position<br>";
> +    } else {
> +        resultString += "FAIL - Element " + id1 + " and Element " + id2 + " had different position<br>";

"positions"

> LayoutTests/fast/transforms/matrix-with-zoom.html:63
> +<p>You should see green box only. If you see red, the test has failed.</p>

I don't think it's useful to have this text in a pixel test.

[Ariya Hidayat]

> r=me. I think we'll have to fix matrix3d() as well; can you file a new bug on that?

Good point. https://bugs.webkit.org/show_bug.cgi?id=51408

> > LayoutTests/fast/transforms/matrix-with-zoom.html:63
> > +<p>You should see green box only. If you see red, the test has failed.</p>
> 
> I don't think it's useful to have this text in a pixel test.

It's useful when running the test from a web browser (I just followed other similar tests).

The patch is also missing a pixel test.

[Ariya Hidayat]

Comment on attachment 77088 [details]
WebCore:

Clearing the review flag. Will update a new one.

[Ariya Hidayat]

Created attachment 77143 [details]
https://bugs.webkit.org/show_bug.cgi?id=49774

[Ariya Hidayat]

Comment on attachment 77143 [details]
https://bugs.webkit.org/show_bug.cgi?id=49774

Clearing flags on attachment: 77143

Committed r74430: <http://trac.webkit.org/changeset/74430>

[Ariya Hidayat]

All reviewed patches have been landed.  Closing bug.