Bug 51338 - [Chromium] v8/SerializedScriptValue::readUint32 treats incoming raw values as signed instead of unsigned
Summary: [Chromium] v8/SerializedScriptValue::readUint32 treats incoming raw values as...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-20 08:31 PST by Andrei Popescu
Modified: 2010-12-20 15:37 PST (History)
3 users (show)

See Also:

Attachments
Use NewFromUnsigned (5.60 KB, patch)
2010-12-20 08:38 PST, Andrei Popescu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Popescu 2010-12-20 08:31:52 PST 
SerializedScriptValue::readUint32() should use v8::Integer::NewFromUnsigned() instead of v8::Integer::New() since the the latter treats the value as a signed integer.
Comment 1 Andrei Popescu 2010-12-20 08:38:55 PST 
Created attachment 77006 [details]
Use NewFromUnsigned
Comment 2 Jeremy Orlow 2010-12-20 08:48:49 PST 
Comment on attachment 77006 [details]
Use NewFromUnsigned

r=me
Comment 3 WebKit Commit Bot 2010-12-20 10:59:53 PST 
The commit-queue encountered the following flaky tests while processing attachment 77006 [details]:

fast/images/load-img-with-empty-src.html bug 50855 (author: mitz@webkit.org)
fast/preloader/script.html bug 50879 (author: abarth@webkit.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2010-12-20 11:35:40 PST 
The commit-queue encountered the following flaky tests while processing attachment 77006 [details]:

fast/preloader/script.html bug 50879 (author: abarth@webkit.org)
fast/loader/recursive-before-unload-crash.html bug 50880 (authors: beidson@apple.com and eric@webkit.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2010-12-20 11:48:02 PST 
The commit-queue encountered the following flaky tests while processing attachment 77006 [details]:

animations/suspend-resume-animation.html bug 48161 (author: cmarrin@apple.com)
animations/play-state-suspend.html bug 50959 (author: cmarrin@apple.com)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2010-12-20 15:37:41 PST 
Comment on attachment 77006 [details]
Use NewFromUnsigned

Clearing flags on attachment: 77006

Committed r74372: <http://trac.webkit.org/changeset/74372>
Comment 7 WebKit Commit Bot 2010-12-20 15:37:47 PST 
All reviewed patches have been landed.  Closing bug.