Bug 51316 – [Qt] Make sure touch and orientation events are disabled in the minimal configuration

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Laszlo Gombos]

Touch and orientation (not device orientation) features are not configurable from build-webkit script so they are not disabled in the minimal config. This means that builds with these features turned off are not tested by any bot.

[Laszlo Gombos]

Created attachment 76971 [details]
proposed patch

[Laszlo Gombos]

Created attachment 76972 [details]
previous patch + bearer mgmt

[Yael]

I don't think this is the right way to add ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to Qt's minimal config.
Instead of adding the flags to Qt's minimal config, they should be added to build-webkit script. From there, they are automatically added to the minimal config.
Please see https://bugs.webkit.org/show_bug.cgi?id=48224 and https://bugs.webkit.org/show_bug.cgi?id=48185.

Qt specific flags like ENABLE_QT_BEARER should be added this way.

[Csaba Osztrogonác]

I agree with Yael, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS should be disabled on all minimal build. They aren't Qt specific features.

[Laszlo Gombos]

Comment on attachment 76972 [details]
previous patch + bearer mgmt

Setting to cq- until bug 51346 is evaluated. Part of this patch will be needed to make sure that ENABLE_TOUCH_EVENTS can be turned off for QtWebKit.

[Eric Seidel (no email)]

Attachment 76972 [details] was posted by a committer and has review+, assigning to Laszlo Gombos for commit.

[Laszlo Gombos]

Comment on attachment 76972 [details]
previous patch + bearer mgmt

Relevant part of the patch committed as http://trac.webkit.org/changeset/75206. Clearing flags.

[Laszlo Gombos]

Closing bug.