WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
48224
build-webkit: add support for --meter-tag switch
https://bugs.webkit.org/show_bug.cgi?id=48224
Summary
build-webkit: add support for --meter-tag switch
Csaba Osztrogonác
Reported
2010-10-25 00:31:18 PDT
This feature is missing. ( revealed by
https://bugs.webkit.org/show_bug.cgi?id=48185
) Yael, could you fix it? Please make sure not to break any port with this new default value.
Attachments
Patch v1
(1.55 KB, patch)
2010-10-25 05:31 PDT
,
David Kilzer (:ddkilzer)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1
2010-10-25 05:16:55 PDT
(In reply to
comment #0
)
> This feature is missing. ( revealed by
https://bugs.webkit.org/show_bug.cgi?id=48185
) > > Yael, could you fix it? Please make sure not to > break any port with this new default value.
Do all ports have this enabled by default, or only some?
David Kilzer (:ddkilzer)
Comment 2
2010-10-25 05:25:03 PDT
(In reply to
comment #1
)
> Do all ports have this enabled by default, or only some?
It looks like GTK disables it in WebCore/GNUmakefile.am, but Qt, Chrome and Apple (Mac) have it enabled.
David Kilzer (:ddkilzer)
Comment 3
2010-10-25 05:31:57 PDT
Created
attachment 71740
[details]
Patch v1 Let the EWS bots check this.
Csaba Osztrogonác
Comment 4
2010-10-26 08:36:02 PDT
Comment on
attachment 71740
[details]
Patch v1 All EWS' are green, except Win-EWS. (It is stucked.) I checked build systems, but it seems that meter tag is disabled on Windows too, because it is missing from FeatureDefines.vsprops. Otherwise LGTM, r=me if you set correct default value for Windows.
Csaba Osztrogonác
Comment 5
2010-10-26 08:36:40 PDT
I'm going to file a new bug to fix FeatureDefines.vsprops .
David Kilzer (:ddkilzer)
Comment 6
2010-10-26 09:30:09 PDT
(In reply to
comment #4
)
> (From update of
attachment 71740
[details]
) > All EWS' are green, except Win-EWS. (It is stucked.) > > I checked build systems, but it seems that meter tag > is disabled on Windows too, because it is missing from > FeatureDefines.vsprops. Otherwise LGTM, r=me if you set > correct default value for Windows.
Okay. Which ports use the vcproj files? Or should I use: !isGtk() && !(isWindows() || isCygwin())
Adam Roben (:aroben)
Comment 7
2010-10-26 09:43:14 PDT
(In reply to
comment #6
)
> Which ports use the vcproj files?
Apple's Windows port, the Cairo/CFLite/libcurl Windows port, and the WinCE port (I think).
Csaba Osztrogonác
Comment 8
2010-10-26 10:03:08 PDT
> !isGtk() && !(isWindows() || isCygwin())
maybe: isQt() || !isGtk() && !(isWindows() || isCygwin()) , because METER_TAG is enabled on Qt, but Qt port has Windows build. But ... it is soooo ugly ...
Adam Roben (:aroben)
Comment 9
2010-10-26 10:04:36 PDT
(In reply to
comment #8
)
> > !isGtk() && !(isWindows() || isCygwin()) > maybe: isQt() || !isGtk() && !(isWindows() || isCygwin()) , > because METER_TAG is enabled on Qt, but Qt port has Windows build. > > But ... it is soooo ugly ...
!isGtk() && !isAppleWinWebKit() should work, assuming GTK and Apple-Win are the only ports where it is disabled.
Csaba Osztrogonác
Comment 10
2010-10-26 10:19:08 PDT
(In reply to
comment #9
)
> !isGtk() && !isAppleWinWebKit() should work, assuming GTK and Apple-Win are the only ports where it is disabled.
OK, I hope we won't break any other ports. :)
David Kilzer (:ddkilzer)
Comment 11
2010-10-26 15:10:36 PDT
(In reply to
comment #10
)
> (In reply to
comment #9
) > > !isGtk() && !isAppleWinWebKit() should work, assuming GTK and Apple-Win are the only ports where it is disabled. > > OK, I hope we won't break any other ports. :)
The Qt Windows ports build with ENABLE_METER_TAG=1, so Adam's suggestion should work. The only port I'm not sure about is WinCairo because I can't find a recent-ish buildbot log for it.
David Kilzer (:ddkilzer)
Comment 12
2010-10-26 21:07:10 PDT
Committed
r70606
: <
http://trac.webkit.org/changeset/70606
>
David Kilzer (:ddkilzer)
Comment 13
2010-10-26 21:07:53 PDT
Comment on
attachment 71740
[details]
Patch v1 Clearing flags.
Brent Fulgham
Comment 14
2010-10-27 10:04:05 PDT
For historical completeness, I just wanted to comment that this change should be fine for the WinCairo port.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug