Bug 51046 – Expose AccessibilityObject::url() to Chromium

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Chris Guillory]

During a chromium code review we determined that we needed access to the url of link accessibility objects.
http://codereview.chromium.org/5751002/

[Chris Guillory]

Created attachment 76552 [details]
Proposed Patch

[Chris Guillory]

WebKit API change.

[Darin Fisher (:fishd, Google)]

Comment on attachment 76552 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76552&action=review

> WebKit/chromium/public/WebAccessibilityObject.h:113
> +    WEBKIT_API WebString url() const;

nit: we ordinarily expose urls using WebURL.  it looks like m_private->url() is a KURL object.  (KURL can be implicitly converted to WebURL.)

[Chris Guillory]

Created attachment 76633 [details]
Patch

Returning as WebURL.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 76633 [details]:

animations/combo-transform-translate+scale.html bug 50958 (authors: [e-mail], [e-mail], [e-mail], and [e-mail])
fast/preloader/script.html bug 50879 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 76633 [details]
Patch

Clearing flags on attachment: 76633

Committed r74171: <http://trac.webkit.org/changeset/74171>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/74171 might have broken Leopard Intel Debug (Tests)