- It uses both glib private data and it allocates its own private structure - It calls parent's dispose method from finalize - webkit_web_plugin_get_mimetypes() uses a wrong annotation for the returned value, it should be transfer none rather than transfer container. - Since the mime type list is internal and we return the list and not a copy, it should never be freed by the caller, so webkit_web_plugin_mime_type_list_free() should be removed from the public API. - Mime types list is used uninitialized - Mention in the docs that list returned by webkit_web_plugin_database_get_plugins() must be freed with webkit_web_plugin_database_plugins_list_free()
Created attachment 76531 [details] Patch to fix the issues
Comment on attachment 76531 [details] Patch to fix the issues View in context: https://bugs.webkit.org/attachment.cgi?id=76531&action=review > WebKit/gtk/webkit/webkitwebplugin.cpp:55 > Are both of these NULL-safe?
Comment on attachment 76531 [details] Patch to fix the issues Seems they are.
Comment on attachment 76531 [details] Patch to fix the issues Clearing flags on attachment: 76531 Committed r74026: <http://trac.webkit.org/changeset/74026>
All reviewed patches have been landed. Closing bug.
The commit-queue encountered the following flaky tests while processing attachment 76531 [details]: fast/loader/recursive-before-unload-crash.html bug 50880 (authors: beidson@apple.com and eric@webkit.org) fast/preloader/script.html bug 50879 (author: abarth@webkit.org) The commit-queue is continuing to process your patch.