RESOLVED FIXED 50989
Change SelectionController::setFocusedNodeIfNeeded code to use DOM traversal instead of render tree traversal 
https://bugs.webkit.org/show_bug.cgi?id=50989
Summary Change SelectionController::setFocusedNodeIfNeeded code to use DOM traversal ...
Emil A Eklund
Reported 2010-12-13 15:28:03 PST
Per comment introduced in bug 49977 by dglazkov@chromium.org, we should use DOM traversal in discovering first focusable node, rather than render tree.
Attachments
Patch (2.27 KB, patch)
2010-12-13 15:32 PST, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2010-12-13 15:30:09 PST
A FIXME comment in setFocusedNodeIfNeeded suggest combining the traversal code with that in EventHandle::dispatchMouseEvent. I don't see how that would simplify things though as they both need to perform different additional checks on the node.
Emil A Eklund
Comment 2 2010-12-13 15:32:15 PST
Created attachment 76456 [details] Patch
Dimitri Glazkov (Google)
Comment 3 2010-12-13 15:36:34 PST
Comment on attachment 76456 [details] Patch ok.
WebKit Review Bot
Comment 4 2010-12-13 16:25:04 PST
Comment on attachment 76456 [details] Patch Clearing flags on attachment: 76456 Committed r73984: <http://trac.webkit.org/changeset/73984>
WebKit Review Bot
Comment 5 2010-12-13 16:25:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.