RESOLVED FIXED 50906
Web Inspector: Protocol cleanup task. Assign domain attribute to Resources and Debugger specific functions. 
https://bugs.webkit.org/show_bug.cgi?id=50906
Summary Web Inspector: Protocol cleanup task. Assign domain attribute to Resources an...
Ilya Tikhonovsky
Reported 2010-12-13 02:16:11 PST
Debugger and Resources related notification functions of Inspector.idl were marked as such with help of "domain" attribute. The other changes in js files are reflecting this change. Some wrappers in WebInspector namespace were dropped, the others were moved to DebuggerModel class.
Attachments
[patch] initialversion. (32.38 KB, patch)
2010-12-13 02:21 PST, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
[patch] second iteration (32.03 KB, patch)
2010-12-13 03:06 PST, Ilya Tikhonovsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2010-12-13 02:21:41 PST
Created attachment 76361 [details] [patch] initialversion. domain attribute was assigned to Resources, Profiler and Debugger notification functions.
Yury Semikhatsky
Comment 2 2010-12-13 02:45:04 PST
Comment on attachment 76361 [details] [patch] initialversion. View in context: https://bugs.webkit.org/attachment.cgi?id=76361&action=review > WebCore/inspector/Inspector.idl:36 > + [notify, fomain=Inspector] void addNodesToSearchResult(out Array nodeIds); fomain -> domain > WebCore/inspector/front-end/ProfilesPanel.js:433 > + addHeapSnapshots: function(uid, chunk) I don't see other places where this method name has changed, did you miss them? > WebCore/inspector/front-end/ProfilesPanel.js:624 > + title: WebInspector.UIString("Recordingâ¦"), The string looks corrupted.
Ilya Tikhonovsky
Comment 3 2010-12-13 03:06:26 PST
Created attachment 76365 [details] [patch] second iteration comments addressed
Yury Semikhatsky
Comment 4 2010-12-13 03:12:32 PST
Comment on attachment 76365 [details] [patch] second iteration View in context: https://bugs.webkit.org/attachment.cgi?id=76365&action=review > WebCore/inspector/front-end/DebuggerModel.js:185 > + too many blank lines
Ilya Tikhonovsky
Comment 5 2010-12-13 03:21:46 PST
Committed r73898 M WebKit/chromium/ChangeLog M WebKit/chromium/src/js/Tests.js M WebCore/ChangeLog M WebCore/inspector/InspectorProfilerAgent.cpp M WebCore/inspector/Inspector.idl M WebCore/inspector/front-end/DebuggerModel.js M WebCore/inspector/front-end/DOMAgent.js M WebCore/inspector/front-end/inspector.js M WebCore/inspector/front-end/ProfilesPanel.js M WebCore/inspector/front-end/ResourceManager.js M WebCore/inspector/InspectorDebuggerAgent.cpp M LayoutTests/http/tests/inspector/debugger-test2.js M LayoutTests/ChangeLog r73898 = 21577ea9200a18a3f7c7e70c2e57662f3c1c2f94 (refs/remotes/trunk)
WebKit Review Bot
Comment 6 2010-12-13 09:05:37 PST
http://trac.webkit.org/changeset/73916 might have broken GTK Linux 64-bit Debug
Note You need to log in before you can comment on or make changes to this bug.