Bug 50808 - [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
Summary: [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Depends on: 50783
  Show dependency treegraph
Reported: 2010-12-10 04:44 PST by Joone Hur
Modified: 2010-12-10 09:16 PST (History)
5 users (show)

See Also:

Proposed Patch (6.50 KB, patch)
2010-12-10 05:08 PST, Joone Hur
no flags Details | Formatted Diff | Diff
Proposed Patch2 (6.49 KB, patch)
2010-12-10 07:32 PST, Joone Hur
mrobinson: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Proposed Patch3 (6.49 KB, patch)
2010-12-10 08:36 PST, Joone Hur
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joone Hur 2010-12-10 04:44:21 PST
Comment 1 Joone Hur 2010-12-10 05:08:22 PST
Created attachment 76184 [details]
Proposed Patch
Comment 2 Martin Robinson 2010-12-10 06:33:13 PST
Comment on attachment 76184 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76184&action=review

> WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h:56
> +    static void addUserStyleSheet(WebKitWebFrame* mainFrame, const char* sourceCode, bool allFrames);

Please remove the mainFrame variable name here.
Comment 3 Joone Hur 2010-12-10 07:32:24 PST
Created attachment 76197 [details]
Proposed Patch2

Yes, I did it.
Comment 4 WebKit Commit Bot 2010-12-10 07:44:11 PST
Comment on attachment 76197 [details]
Proposed Patch2

Rejecting attachment 76197 [details] from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-sf', 'apply-attachment', '--non-interactive', 76197]" exit_code: 2
Last 500 characters of output:
patching file WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h
Hunk #1 FAILED at 53.
1 out of 1 hunk FAILED -- saving rejects to file WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h.rej
patching file WebKitTools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp

Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Martin Robinson', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/6896027
Comment 5 Joone Hur 2010-12-10 08:36:24 PST
Created attachment 76206 [details]
Proposed Patch3

I fixed the confict with http://trac.webkit.org/changeset/73727
Comment 6 WebKit Commit Bot 2010-12-10 09:16:27 PST
Comment on attachment 76206 [details]
Proposed Patch3

Clearing flags on attachment: 76206

Committed r73735: <http://trac.webkit.org/changeset/73735>
Comment 7 WebKit Commit Bot 2010-12-10 09:16:33 PST
All reviewed patches have been landed.  Closing bug.