Bug 50808 – [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Joone Hur]

Unskipping:
#userscripts/mixed-case-stylesheet.html
#userscripts/simple-stylesheet.html
#userscripts/user-style-all-frames.html

[Joone Hur]

Created attachment 76184 [details]
Proposed Patch

[Martin Robinson]

Comment on attachment 76184 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76184&action=review

> WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h:56
> +    static void addUserStyleSheet(WebKitWebFrame* mainFrame, const char* sourceCode, bool allFrames);

Please remove the mainFrame variable name here.

[Joone Hur]

Created attachment 76197 [details]
Proposed Patch2

Yes, I did it.

[WebKit Commit Bot]

Comment on attachment 76197 [details]
Proposed Patch2

Rejecting attachment 76197 [details] from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-sf', 'apply-attachment', '--non-interactive', 76197]" exit_code: 2
Last 500 characters of output:
pRenderTreeSupportGtk.cpp
patching file WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h
Hunk #1 FAILED at 53.
1 out of 1 hunk FAILED -- saving rejects to file WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h.rej
patching file WebKitTools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp

Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Martin Robinson', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/6896027

[Joone Hur]

Created attachment 76206 [details]
Proposed Patch3

I fixed the confict with http://trac.webkit.org/changeset/73727

[WebKit Commit Bot]

Comment on attachment 76206 [details]
Proposed Patch3

Clearing flags on attachment: 76206

Committed r73735: <http://trac.webkit.org/changeset/73735>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.