Bug 50783 – [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Joone Hur]

We need to implement pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet in LayoutTestControllerGtk.cpp
for unskipping:
     printing/page-rule-selection.html
     printing/page-format-data.html

[Joone Hur]

Created attachment 76177 [details]
Proposed Patch1

[WebKit Review Bot]

Attachment 76177 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/gtk/Skipped', u'WebKit/gtk/ChangeLog', u'WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp', u'WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h', u'WebKitTools/ChangeLog', u'WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp']" exit_code: 1
WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:58:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Seidel (no email)]

Comment on attachment 76177 [details]
Proposed Patch1

LGTM.

[WebKit Commit Bot]

Comment on attachment 76177 [details]
Proposed Patch1

Clearing flags on attachment: 76177

Committed r73714: <http://trac.webkit.org/changeset/73714>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/73714 might have broken GTK Linux 32-bit Debug

[Joone Hur]

(In reply to comment #6)
> http://trac.webkit.org/changeset/73714 might have broken GTK Linux 32-bit Debug

I tested it, but no build break.