The commit-queue should file bugs about flaky tests it encounters

[Eric Seidel (no email)]

The commit-queue should file bugs about flaky tests it encounters

[Eric Seidel (no email)]

Created attachment 76164 [details]
Patch

[Eric Seidel (no email)]

webkit-patch suggest-reviewers was a bit overzealous for this bug.  I think we should probably limit it to 5 CCs or something.

[Eric Seidel (no email)]

Dropping most of the CC's feel free to add yourself back of course.

[Eric Seidel (no email)]

Created attachment 76166 [details]
upload the right patch

[Adam Barth]

Comment on attachment 76166 [details]
upload the right patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76166&action=review

I fear this will annoy people too much, but it seems better than our previous design.

> WebKitTools/Scripts/webkitpy/tool/bot/flakytestreporter.py:102
> +            latest_flake_message = "The %s just saw %s flake while processing patch %s on bug %s." % (self._bot_name, flaky_test, patch.id(), patch.bug_id())

You should say attachment instead of patch to get autolinking to work.

[Daniel Bates]

Comment on attachment 76166 [details]
upload the right patch

View in context: https://bugs.webkit.org/attachment.cgi?id=76166&action=review

> WebKitTools/Scripts/webkitpy/common/config/urls.py:1
> +# Copyright (c) 2010, Google Inc. All rights reserved.

Casually looked at this patch and noticed that you have an extraneous comma after 2010.

[Eric Seidel (no email)]

Committed r73692: <http://trac.webkit.org/changeset/73692>

[Eric Seidel (no email)]

Committed r73694: <http://trac.webkit.org/changeset/73694>

[Eric Seidel (no email)]

You can see the first two it's filed here:
https://bugs.webkit.org/show_bug.cgi?id=50822
https://bugs.webkit.org/show_bug.cgi?id=50823

[Eric Seidel (no email)]

*** Bug 45740 has been marked as a duplicate of this bug. ***