Bug 50705 – [GTK] DRT needs layoutTestController.setCacheModel

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Joone Hur]

Releated change set:
http://trac.webkit.org/changeset/44591

[Joone Hur]

Created attachment 75944 [details]
Proposed Patch

[WebKit Review Bot]

Attachment 75944 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKitTools/ChangeLog', u'WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp']" exit_code: 1
WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:569:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Martin Robinson]

Comment on attachment 75944 [details]
Proposed Patch

Okay. It seems that the one test that uses this is already passing. It's good to have an implementation though.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 75944 [details]:

animations/suspend-resume-animation.html
fast/preloader/script.html

Please file bugs against the tests.  These tests were authored by [e-mail] and [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 75944 [details]
Proposed Patch

Rejecting patch 75944 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2
Last 500 characters of output:
ociatedElement.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
	CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/FrameLoader.o /Projects/CommitQueue/WebCore/loader/FrameLoader.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
	CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/FrameView.o /Projects/CommitQueue/WebCore/page/FrameView.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
(22 failures)


Full output: http://queues.webkit.org/results/6975006

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 75944 [details]:

fast/loader/recursive-before-unload-crash.html
fast/images/load-img-with-empty-src.html

Please file bugs against the tests.  These tests were authored by [e-mail], [e-mail], and [e-mail].  The commit-queue is continuing to process your patch.

[Joone Hur]

Created attachment 76213 [details]
Proposed Patch2

I don't understand why Mac buildbot failed to build WebKit due to this patch.
Anyway, I submitted the patch again.

[WebKit Review Bot]

Attachment 76213 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--diff-files', u'WebKitTools/ChangeLog', u'WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp']" exit_code: 1
WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:568:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Joone Hur]

Created attachment 76215 [details]
Proposed Patch3

Fixed the style error.

[WebKit Commit Bot]

Comment on attachment 76215 [details]
Proposed Patch3

Clearing flags on attachment: 76215

Committed r73751: <http://trac.webkit.org/changeset/73751>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.