WebKitTestRunner needs layoutTestController.setCacheModel
<rdar://problem/8213860>
Created attachment 174130 [details] Patch
Comment on attachment 174130 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174130&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:44 > +WK_EXPORT void WKBundleSetCacheModel(WKBundleRef bundle, uint32_t cacheModel); 'bundle' can be omitted.
Comment on attachment 174130 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174130&action=review >> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:44 >> +WK_EXPORT void WKBundleSetCacheModel(WKBundleRef bundle, uint32_t cacheModel); > > 'bundle' can be omitted. No other function in this file is omitting "bundle" so it would look inconsistent.
Comment on attachment 174130 [details] Patch Attachment 174130 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14834277
Comment on attachment 174130 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174130&action=review >>> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:44 >>> +WK_EXPORT void WKBundleSetCacheModel(WKBundleRef bundle, uint32_t cacheModel); >> >> 'bundle' can be omitted. > > No other function in this file is omitting "bundle" so it would look inconsistent. ok
Created attachment 174139 [details] Patch
Any feedback on this patch?
Comment on attachment 174139 [details] Patch Clearing flags on attachment: 174139 Committed r135508: <http://trac.webkit.org/changeset/135508>
All reviewed patches have been landed. Closing bug.