Bug 42684 - WebKitTestRunner needs layoutTestController.setCacheModel
Summary: WebKitTestRunner needs layoutTestController.setCacheModel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 50705
  Show dependency treegraph
 
Reported: 2010-07-20 15:13 PDT by Sam Weinig
Modified: 2012-11-22 05:24 PST (History)
7 users (show)

See Also:


Attachments
Patch (10.02 KB, patch)
2012-11-14 04:40 PST, Chris Dumez
buildbot: commit-queue-
Details | Formatted Diff | Diff
Patch (9.77 KB, patch)
2012-11-14 05:44 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-07-20 15:13:24 PDT
WebKitTestRunner needs layoutTestController.setCacheModel
Comment 1 Sam Weinig 2010-07-20 15:32:23 PDT
<rdar://problem/8213860>
Comment 2 Chris Dumez 2012-11-14 04:40:34 PST
Created attachment 174130 [details]
Patch
Comment 3 Mikhail Pozdnyakov 2012-11-14 04:52:51 PST
Comment on attachment 174130 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174130&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:44
> +WK_EXPORT void WKBundleSetCacheModel(WKBundleRef bundle, uint32_t cacheModel);

'bundle' can be omitted.
Comment 4 Chris Dumez 2012-11-14 04:55:14 PST
Comment on attachment 174130 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174130&action=review

>> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:44
>> +WK_EXPORT void WKBundleSetCacheModel(WKBundleRef bundle, uint32_t cacheModel);
> 
> 'bundle' can be omitted.

No other function in this file is omitting "bundle" so it would look inconsistent.
Comment 5 Build Bot 2012-11-14 05:00:03 PST
Comment on attachment 174130 [details]
Patch

Attachment 174130 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14834277
Comment 6 Mikhail Pozdnyakov 2012-11-14 05:17:52 PST
Comment on attachment 174130 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=174130&action=review

>>> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:44
>>> +WK_EXPORT void WKBundleSetCacheModel(WKBundleRef bundle, uint32_t cacheModel);
>> 
>> 'bundle' can be omitted.
> 
> No other function in this file is omitting "bundle" so it would look inconsistent.

ok
Comment 7 Chris Dumez 2012-11-14 05:44:46 PST
Created attachment 174139 [details]
Patch
Comment 8 Chris Dumez 2012-11-18 11:55:47 PST
Any feedback on this patch?
Comment 9 WebKit Review Bot 2012-11-22 05:24:26 PST
Comment on attachment 174139 [details]
Patch

Clearing flags on attachment: 174139

Committed r135508: <http://trac.webkit.org/changeset/135508>
Comment 10 WebKit Review Bot 2012-11-22 05:24:31 PST
All reviewed patches have been landed.  Closing bug.