Bug 50596 - new-run-webkit-tests keels over if it can't start the http server on windows
Summary: new-run-webkit-tests keels over if it can't start the http server on windows
Status: RESOLVED DUPLICATE of bug 59977
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-06 15:45 PST by Dirk Pranke
Modified: 2011-05-02 18:12 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2010-12-06 15:45:28 PST 
2010-12-05 09:48:46,099 3412 run_webkit_tests.py:619 INFO Exception raised, exiting
Traceback (most recent call last):
  File "e:\b\build\slave\Webkit_Win__dbg__2_\build\src\third_party\WebKit\WebKitTools\Scripts\new-run-webkit-tests", line 38, in <module>
    sys.exit(run_webkit_tests.main())
  File "e:\b\build\slave\Webkit_Win__dbg__2_\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\run_webkit_tests.py", line 1636, in main
    return run(port_obj, options, args)
  File "e:\b\build\slave\Webkit_Win__dbg__2_\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\run_webkit_tests.py", line 1328, in run
    num_unexpected_results = test_runner.run(result_summary)
  File "e:\b\build\slave\Webkit_Win__dbg__2_\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\run_webkit_tests.py", line 722, in run
    self._run_tests(failures.keys(), retry_summary)
  File "e:\b\build\slave\Webkit_Win__dbg__2_\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\run_webkit_tests.py", line 612, in _run_tests
    message_broker.run_message_loop()
  File "e:\b\build\slave\Webkit_Win__dbg__2_\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\layout_package\dump_render_tree_thread.py", line 337, in _covered_run
    self._run(test_runner=None, result_summary=None)
  File "e:\b\build\slave\Webkit_Win__dbg__2_\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\layout_package\dump_render_tree_thread.py", line 414, in _run
    self._start_servers_with_lock()
  File "e:\b\build\slave\Webkit_Win__dbg__2_\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\layout_package\dump_render_tree_thread.py", line 548, in _start_servers_with_lock
    self._port.start_http_server()
  File "e:\b\build\slave\Webkit_Win__dbg__2_\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\port\base.py", line 540, in start_http_server
    self._http_server.start()
  File "e:\b\build\slave\Webkit_Win__dbg__2_\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\port\http_server.py", line 213, in start
    raise google.httpd_utils.HttpdNotStarted('Failed to start httpd.')
NameError: global name 'google' is not defined
program finished with exit code 

The 'google' reference is left over from when this code lived in the chromium repository. There's actually a HttpdNotStarted exception declared in the file that should be used instead.

That said, the calling code is totally unprepared for this call to fail, and we don't clean up things nicely.
Comment 1 Dirk Pranke 2011-05-02 18:12:51 PDT 

*** This bug has been marked as a duplicate of bug 59977 ***