Web Inspector: remove duplicate code for capturing stack trace
Created attachment 75505 [details] Patch
Created attachment 75512 [details] Patch
Committed r73351.
Hi, This patch seems to cause new crashes in ~10 tests on Chromium canary buildbots: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&master=ChromiumWebkit&tests=http%2Ftests%2Fplugins%2Fplugin-document-has-focus.html%2Cplugins%2Fdocument-open.html%2Cplugins%2Fgeturlnotify-during-document-teardown.html%2Cplugins%2Fnetscape-plugin-map-data-to-src.html%2Cplugins%2Fnetscape-plugin-setwindow-size-2.html%2Cplugins%2Fnetscape-plugin-setwindow-size.html%2Cplugins%2Fopen-and-close-window-with-plugin.html%2Cplugins%2Fwindow-open.html Stack trace looks like: [11686:11686:4179036940080:ERROR:base/process_util_posix.cc(106)] Received signal 11 base::debug::StackTrace::StackTrace() [0x81173f9] base::(anonymous namespace)::StackDumpSignalHandler() [0x8104769] 0x4001c420 WebCore::Console::log() [0x8919db2] WebCore::ConsoleInternal::logCallback() [0x8539485] v8::internal::Builtin_HandleApiCall() [0x81b34a1] I'm going to roll out this change if I do not hear from you in next one hour. I appreciate your cooperation.
This patch was rolled out at r73355 and the bots are getting back to normal. Reopening this bug for the record. Thanks!
Created attachment 75693 [details] Patch fixing plugin test failures
Committed r73366