Bug 50461 - [v8] Web Inspector: remove duplicate code for capturing stack trace
Summary: [v8] Web Inspector: remove duplicate code for capturing stack trace
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on: 50560
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-03 10:08 PST by Yury Semikhatsky
Modified: 2010-12-06 07:40 PST (History)
11 users (show)

See Also:


Attachments
Patch (10.79 KB, patch)
2010-12-03 10:10 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
Patch (14.43 KB, patch)
2010-12-03 10:46 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
Patch fixing plugin test failures (14.86 KB, patch)
2010-12-06 07:22 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2010-12-03 10:08:23 PST
Web Inspector: remove duplicate code for capturing stack trace
Comment 1 Yury Semikhatsky 2010-12-03 10:10:40 PST
Created attachment 75505 [details]
Patch
Comment 2 Yury Semikhatsky 2010-12-03 10:46:22 PST
Created attachment 75512 [details]
Patch
Comment 3 Yury Semikhatsky 2010-12-06 02:17:52 PST
Committed r73351.
Comment 4 Yuta Kitamura 2010-12-06 03:07:45 PST
Hi,

This patch seems to cause new crashes in ~10 tests on Chromium canary buildbots:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&master=ChromiumWebkit&tests=http%2Ftests%2Fplugins%2Fplugin-document-has-focus.html%2Cplugins%2Fdocument-open.html%2Cplugins%2Fgeturlnotify-during-document-teardown.html%2Cplugins%2Fnetscape-plugin-map-data-to-src.html%2Cplugins%2Fnetscape-plugin-setwindow-size-2.html%2Cplugins%2Fnetscape-plugin-setwindow-size.html%2Cplugins%2Fopen-and-close-window-with-plugin.html%2Cplugins%2Fwindow-open.html

Stack trace looks like:

[11686:11686:4179036940080:ERROR:base/process_util_posix.cc(106)] Received signal 11
	base::debug::StackTrace::StackTrace() [0x81173f9]
	base::(anonymous namespace)::StackDumpSignalHandler() [0x8104769]
	0x4001c420
	WebCore::Console::log() [0x8919db2]
	WebCore::ConsoleInternal::logCallback() [0x8539485]
	v8::internal::Builtin_HandleApiCall() [0x81b34a1]


I'm going to roll out this change if I do not hear from you in next one hour. I appreciate your cooperation.
Comment 5 Yuta Kitamura 2010-12-06 04:21:47 PST
This patch was rolled out at r73355 and the bots are getting back to normal.

Reopening this bug for the record.

Thanks!
Comment 6 Yury Semikhatsky 2010-12-06 07:22:47 PST
Created attachment 75693 [details]
Patch fixing plugin test failures
Comment 7 Yury Semikhatsky 2010-12-06 07:40:37 PST
Committed r73366