Bug 50456 - Remove one row/column of renderers
Summary: Remove one row/column of renderers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 50023
Blocks:
  Show dependency tree / graph
 
Reported: 2010-12-03 05:52 PST by Alex Bredariol Grilo
Modified: 2010-12-13 12:38 PST (History)
9 users (show)

See Also:

Attachments
Patch (9.82 KB, patch)
2010-12-03 05:55 PST, Alex Bredariol Grilo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Bredariol Grilo 2010-12-03 05:52:02 PST 
Remove one row/column of renderers
Comment 1 Alex Bredariol Grilo 2010-12-03 05:55:20 PST 
Created attachment 75493 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-12-13 00:23:57 PST 
Who should review this?  It's not at all clear to me how to evaluate this patch.  I could just rubber-stamp it, but I don't really know who is in charge of the EFL side of things.
Comment 3 Antonio Gomes 2010-12-13 07:30:15 PST 
Comment on attachment 75493 [details]
Patch

Could other guys who know the EFL backing store code review this too?
Comment 4 Lucas De Marchi 2010-12-13 07:53:28 PST 
Comment on attachment 75493 [details]
Patch

LGTM.

Eric / Antonio, could you rubber stamp it?
Comment 5 Rafael Antognolli 2010-12-13 08:26:52 PST 
Hello Eric and Antonio,

Lucas De Marchi, Leandro Pereira and me are currently making informal reviews on the EFL port, since we are also EFL developers and are working on it. But I forgot to make a review on this patch because I had already internally reviewed it for Alex.

Anyway, Lucas already said enough.
Comment 6 Rafael Antognolli 2010-12-13 08:27:56 PST 
Please also notice that this patch depends on bug 50023.
Comment 7 Andreas Kling 2010-12-13 08:30:28 PST 
Comment on attachment 75493 [details]
Patch

*handwave*
Comment 8 WebKit Review Bot 2010-12-13 09:55:23 PST 
The commit-queue encountered the following flaky tests while processing attachment 75493 [details]:

inspector/syntax-highlight-css.html bug 50930 (authors: keishi@webkit.org, pfeldman@chromium.org, and yurys@chromium.org)
The commit-queue is continuing to process your patch.
Comment 9 WebKit Review Bot 2010-12-13 09:57:02 PST 
Comment on attachment 75493 [details]
Patch

Clearing flags on attachment: 75493

Committed r73924: <http://trac.webkit.org/changeset/73924>
Comment 10 WebKit Review Bot 2010-12-13 09:57:08 PST 
All reviewed patches have been landed.  Closing bug.
Comment 11 WebKit Commit Bot 2010-12-13 12:38:19 PST 
The commit-queue encountered the following flaky tests while processing attachment 75493 [details]:

animations/combo-transform-translate+scale.html bug 50958 (authors: cmarrin@apple.com, darin@apple.com, ojan@chromium.org, and pol@apple.com)
animations/play-state-suspend.html bug 50959 (author: cmarrin@apple.com)
The commit-queue is continuing to process your patch.