Bug 50023 – [EFL] Remove adjacent tiles rendering queue

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Alex Bredariol Grilo]

[EFL] Remove adjacent tiles rendering queue

[Alex Bredariol Grilo]

Created attachment 74758 [details]
Patch

[Lucas De Marchi]

Comment on attachment 74758 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74758&action=review

> WebKit/efl/ChangeLog:7
> +

Could you give more details on what exactly you are doing? Is this a fix for a bug?

> WebKit/efl/ChangeLog:20
> +

And, please, detail the important changes above.

[Alex Bredariol Grilo]

Created attachment 76187 [details]
Patch

[Rafael Antognolli]

(In reply to comment #3)
> Created an attachment (id=76187) [details]
> Patch

Patch looks good to me.

[Andreas Kling]

Comment on attachment 76187 [details]
Patch

rs=me

[WebKit Commit Bot]

Comment on attachment 76187 [details]
Patch

Rejecting attachment 76187 [details] from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2
Last 500 characters of output:
pple.compilers.gcc.4_2
	CompileC /Projects/CommitQueue/WebKitBuild/WebKit.build/Release/WebKit.build/Objects-normal/x86_64/WebViewEventHandling.o /Projects/CommitQueue/WebKit/mac/WebView/WebViewEventHandling.mm normal x86_64 objective-c++ com.apple.compilers.gcc.4_2
	CompileC /Projects/CommitQueue/WebKitBuild/WebKit.build/Release/WebKit.build/Objects-normal/x86_64/WebView.o /Projects/CommitQueue/WebKit/mac/WebView/WebView.mm normal x86_64 objective-c++ com.apple.compilers.gcc.4_2
(41 failures)


Full output: http://queues.webkit.org/results/7000098

[Lucas De Marchi]

(In reply to comment #6)
> (From update of attachment 76187 [details])
> Rejecting attachment 76187 [details] from commit-queue.
> 
> Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2
> Last 500 characters of output:
> pple.compilers.gcc.4_2
>     CompileC /Projects/CommitQueue/WebKitBuild/WebKit.build/Release/WebKit.build/Objects-normal/x86_64/WebViewEventHandling.o /Projects/CommitQueue/WebKit/mac/WebView/WebViewEventHandling.mm normal x86_64 objective-c++ com.apple.compilers.gcc.4_2
>     CompileC /Projects/CommitQueue/WebKitBuild/WebKit.build/Release/WebKit.build/Objects-normal/x86_64/WebView.o /Projects/CommitQueue/WebKit/mac/WebView/WebView.mm normal x86_64 objective-c++ com.apple.compilers.gcc.4_2
> (41 failures)
> 
> 

I forgot the commit bot does not handle dependencies. Alex, could you rebase your patch and re-send it?

[Eric Seidel (no email)]

I'm not sure what you mean by "dependencies".

[Lucas De Marchi]

(In reply to comment #8)
> I'm not sure what you mean by "dependencies".

Sorry, I thought the error was that the patch didn't apply after patch in bug 50456 has landed.

Actually the bug was with building mac port. Since this patch does not touch any file other than WebKit/efl/ewk/ewk_tiled_backing_store.c, maybe it's safe to cq+ again?

[Lucas De Marchi]

Comment on attachment 76187 [details]
Patch

let's try again.

[WebKit Commit Bot]

Comment on attachment 76187 [details]
Patch

Rejecting attachment 76187 [details] from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2
Last 500 characters of output:
l x86_64 c++ com.apple.compilers.gcc.4_2
	CompileC /Projects/CommitQueue/WebKitBuild/WebKit2.build/Release/WebKit2.build/Objects-normal/x86_64/WebProcessProxy.o /Projects/CommitQueue/WebKit2/UIProcess/WebProcessProxy.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
	CompileC /Projects/CommitQueue/WebKitBuild/WebKit2.build/Release/WebKit2.build/Objects-normal/x86_64/WebPage.o /Projects/CommitQueue/WebKit2/WebProcess/WebPage/WebPage.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
(6 failures)


Full output: http://queues.webkit.org/results/6938121

[Eric Seidel (no email)]

Comment on attachment 76187 [details]
Patch

Clearly one of the cq nodes is having trouble.  Not sure why.

[WebKit Commit Bot]

Comment on attachment 76187 [details]
Patch

Rejecting attachment 76187 [details] from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2
Last 500 characters of output:
itQueue/WebKitBuild/WebKit2.build/Release/WebKit2.build/Objects-normal/x86_64/AuthenticationChallengeProxy.o /Projects/CommitQueue/WebKit2/UIProcess/Authentication/AuthenticationChallengeProxy.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
	CompileC /Projects/CommitQueue/WebKitBuild/WebKit2.build/Release/WebKit2.build/Objects-normal/x86_64/WebDatabaseManagerProxy.o /Projects/CommitQueue/WebKit2/UIProcess/WebDatabaseManagerProxy.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
(13 failures)


Full output: http://queues.webkit.org/results/6975095

[Eric Seidel (no email)]

I'm really not sure what's going on here.  Maybe my commit bot node has been failing constantly for all patches?  I'm not sure how this one failed 3 times in a row like that?

[Lucas De Marchi]

Comment on attachment 76187 [details]
Patch

Clearing flags on attachment: 76187

Committed r73990: <http://trac.webkit.org/changeset/73990>

[Lucas De Marchi]

All reviewed patches have been landed.  Closing bug.