In the patch for bug 50211, only platform/mac and platform/chromium-linux are addressed. Platform-specific expectation files are also necessary on platform/mac-leopard and platform/chromium-win.
Chromium-mac needs some love, too. Probably just fixing mac-leopard should be enough.
Created attachment 75857 [details] Updated expectation files Finishing the work on bug 50211. (In reply to comment #1) > Chromium-mac needs some love, too. Probably just fixing mac-leopard should be enough. The chromium-mac test runs fine on my Snow Leopard. I suppose the failure I'm seeing on webkit's official chromium-mac tests is happening because those tests are run on Leopard (not Snow Leopard). Oddly enough, I didn't find the official test output on (non-chromium) Leopard. I am submitting what I got from chromium-mac. I hope that will work.
Some Chromium's Mac bots still run 10.5 (Leopard). That's why they are failing. The patch looks good to me. (I'm not an reviewer so I can't r+ it)
(In reply to comment #3) > Some Chromium's Mac bots still run 10.5 (Leopard). That's why they are failing. > The patch looks good to me. (I'm not an reviewer so I can't r+ it) Ok, now I understand what's going on on chromium-mac, although I still can't understand why did I not find an output image in the runs "Leopard Intel Debug (Tests)" and "Leopard Intel Release (Tests)". Thank you for looking at my patch. I will wait for another reviewer to give me an r+ and cq+.
Attachment 75857 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/update-webkit']" exit_code: 2 Updating OpenSource Incomplete data: Delta source ended unexpectedly at /usr/lib/git-core/git-svn line 5061 Died at WebKitTools/Scripts/update-webkit line 132. If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #5) > Attachment 75857 [details] did not pass style-queue: > > [...] > > If any of these errors are false positives, please file a bug against check-webkit-style. It is a false positive indeed. I opened the bug 50688.
Comment on attachment 75857 [details] Updated expectation files ok
Comment on attachment 75857 [details] Updated expectation files Rejecting patch 75857 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 1 ERROR: Working directory has local commits, pass --force-clean to continue. Full output: http://queues.webkit.org/results/6954007
Comment on attachment 75857 [details] Updated expectation files Sigh. We really need to fix this bug.
The commit-queue encountered the following flaky tests while processing attachment 75857 [details]: fast/preloader/script.html fast/js/exceptions-thrown-in-callbacks.html Please file bugs against the tests. These tests were authored by abarth@webkit.org and oliver@apple.com. The commit-queue is continuing to process your patch.
Was bug 49798.
Comment on attachment 75857 [details] Updated expectation files Rejecting patch 75857 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 1 ERROR: Working directory has local commits, pass --force-clean to continue. Full output: http://queues.webkit.org/results/6947017
Comment on attachment 75857 [details] Updated expectation files A patch to hopefully fix this local commit problem is in flight.
Adam and Eric, thanks!
Comment on attachment 75857 [details] Updated expectation files Rejecting patch 75857 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 1 ERROR: Working directory has local commits, pass --force-clean to continue. Full output: http://queues.webkit.org/results/6911022
Comment on attachment 75857 [details] Updated expectation files Wow, this problem is much worse than thought. Still working.
Comment on attachment 75857 [details] Updated expectation files Clearing flags on attachment: 75857 Committed r73637: <http://trac.webkit.org/changeset/73637>
All reviewed patches have been landed. Closing bug.