Bug 50211 - Fix testcase: textPath cannot be inside another textPath
Summary: Fix testcase: textPath cannot be inside another textPath
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 47759
  Show dependency treegraph
 
Reported: 2010-11-29 23:12 PST by Cosmin Truta
Modified: 2010-12-06 17:38 PST (History)
4 users (show)

See Also:


Attachments
Fixed test and updated expectation files (102.99 KB, patch)
2010-11-30 22:21 PST, Cosmin Truta
no flags Details | Formatted Diff | Diff
Fixed test and updated expectation files (105.58 KB, patch)
2010-11-30 22:36 PST, Cosmin Truta
no flags Details | Formatted Diff | Diff
Fixed test and updated expectation files (105.69 KB, patch)
2010-11-30 22:51 PST, Cosmin Truta
zimmermann: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Fixed test and updated expectation files (105.63 KB, patch)
2010-12-06 09:24 PST, Cosmin Truta
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cosmin Truta 2010-11-29 23:12:30 PST
I am opening this bug in order to fix svg/custom/text-linking.svg.
The resolution of the bug 47759 depends on this one.

Here are the relevant excerpts from the SVG content model:
<text> may contain: 'a', ‘altGlyph’, ‘textPath’, ‘tref’, ‘tspan’
<tspan> may contain: 'a', 'altGlyph', 'tref', 'tspan'
<tref> may contain: nothing
<textPath> may contain: 'a', 'tref', 'tspan'
<altGlyph> may contain: any element or character data
<a> may contain: any element that its parent may contain, except itself

According to this, <textPath> cannot contain <text>, and there is no other possible way in which to put <textPath> inside another <textPath>.
Comment 1 Cosmin Truta 2010-11-29 23:55:49 PST
Kindly asking Rob to rebaseline, after removing the last <text> line from testcase.
Comment 2 Cosmin Truta 2010-11-29 23:58:51 PST
For the record: this was introduced in bug 46460, attachment 70961 [details].
Comment 3 Cosmin Truta 2010-11-30 22:21:01 PST
Created attachment 75251 [details]
Fixed test and updated expectation files

To do in bug 50310:
Update the expectation files under platform/mac-leopard/ and platform/chromium-win/
Remove the BUGWK50310 line inside platform/chromium/test_expectations.txt
Comment 4 Cosmin Truta 2010-11-30 22:36:46 PST
Created attachment 75253 [details]
Fixed test and updated expectation files

Same as before, but slightly beautified.
Comment 5 Cosmin Truta 2010-11-30 22:51:11 PST
Created attachment 75254 [details]
Fixed test and updated expectation files

Sync'ed master to avoid the patch failure on platform/chromium/test-expectations.txt
Comment 6 Nikolas Zimmermann 2010-12-01 02:03:59 PST
Comment on attachment 75254 [details]
Fixed test and updated expectation files

LGTM, r=me.
Comment 7 WebKit Commit Bot 2010-12-02 09:13:54 PST
Comment on attachment 75254 [details]
Fixed test and updated expectation files

Rejecting patch 75254 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', 75254]" exit_code: 2
Last 500 characters of output:
ectations.txt
Hunk #1 FAILED at 3206.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej
patching file LayoutTests/platform/mac/svg/custom/text-linking-expected.checksum
patching file LayoutTests/platform/mac/svg/custom/text-linking-expected.txt
patching file LayoutTests/svg/custom/text-linking.svg

Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Nikolas Zimmermann', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/6748011
Comment 8 Cosmin Truta 2010-12-06 09:24:46 PST
Created attachment 75705 [details]
Fixed test and updated expectation files

This was r+'ed and cq+'ed, but failed to commit because test_expectations.txt went out of sync.
Given that I don't have cq+ permissions, could you please do the same on this rebaselined patch?
Comment 9 Eric Seidel (no email) 2010-12-06 11:49:08 PST
Comment on attachment 75705 [details]
Fixed test and updated expectation files

OK.
Comment 10 WebKit Commit Bot 2010-12-06 14:53:54 PST
The commit-queue encountered the following flaky tests while processing attachment 75705 [details]:

compositing/tiling/huge-layer-resize.html
java/lc3/JavaObject/JavaObjectToDouble-001.html

Please file bugs against the tests.  These tests were authored by ap@webkit.org and simon.fraser@apple.com.  The commit-queue is continuing to process your patch.
Comment 11 WebKit Commit Bot 2010-12-06 16:57:19 PST
The commit-queue encountered the following flaky tests while processing attachment 75705 [details]:

inspector/styles-new-API.html

Please file bugs against the tests.  These tests were authored by apavlov@chromium.org and pfeldman@chromium.org.  The commit-queue is continuing to process your patch.
Comment 12 WebKit Commit Bot 2010-12-06 16:58:26 PST
Comment on attachment 75705 [details]
Fixed test and updated expectation files

Clearing flags on attachment: 75705

Committed r73415: <http://trac.webkit.org/changeset/73415>
Comment 13 WebKit Commit Bot 2010-12-06 16:58:33 PST
All reviewed patches have been landed.  Closing bug.
Comment 14 WebKit Commit Bot 2010-12-06 17:38:01 PST
The commit-queue encountered the following flaky tests while processing attachment 75705 [details]:

fast/loader/recursive-before-unload-crash.html
animations/combo-transform-translate+scale.html

Please file bugs against the tests.  These tests were authored by beidson@apple.com, cmarrin@apple.com, darin@apple.com, eric@webkit.org, ojan@chromium.org, and pol@apple.com.  The commit-queue is continuing to process your patch.