Bug 50256 – Web Inspector: [CRASH] on "Revert to this revision" of style with import.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

1. Go to apple.com
2. Open inspector
3. edit font-size in body's selector
4. Revert to original in the resources tab

CRASH:

#0	0x1016cdc81 in WebCore::Document::removePendingSheet at Document.cpp:2856
#1	0x10195e1ce in WebCore::HTMLLinkElement::sheetLoaded at HTMLLinkElement.cpp:362
#2	0x10167bc70 in WebCore::CSSStyleSheet::checkLoaded at CSSStyleSheet.cpp:232
#3	0x102024bf1 in WebCore::StyleBase::checkLoaded at StyleBase.cpp:40
#4	0x10167bc3b in WebCore::CSSStyleSheet::checkLoaded at CSSStyleSheet.cpp:226
#5	0x1015f0283 in WebCore::CSSImportRule::setCSSStyleSheet at CSSImportRule.cpp:104
#6	0x10153f545 in WebCore::CachedCSSStyleSheet::didAddClient at CachedCSSStyleSheet.cpp:57
#7	0x1015470a7 in WebCore::CachedResource::addClient at CachedResource.cpp:216
#8	0x1015ef8c7 in WebCore::CSSImportRule::insertedIntoParent at CSSImportRule.cpp:148
#9	0x102029f82 in WebCore::StyleList::append at StyleList.cpp:35
#10	0x1015e4848 in cssyyparse at CSSGrammar.y:385
#11	0x10160d2e3 in WebCore::CSSParser::parseSheet at CSSParser.cpp:233
#12	0x10167bf98 in WebCore::CSSStyleSheet::parseStringAtLine at CSSStyleSheet.cpp:206
#13	0x10167bff3 in WebCore::CSSStyleSheet::parseString at CSSStyleSheet.cpp:199
#14	0x101a91e4d in WebCore::InspectorStyleSheet::reparseStyleSheet at InspectorStyleSheet.cpp:590
#15	0x101a2ffa2 in WebCore::InspectorCSSAgent::setStyleSheetText2 at InspectorCSSAgent.cpp:298

Here is where it crashes:

// This method is called whenever a top-level stylesheet has finished loading.
void Document::removePendingSheet()
{
    // Make sure we knew this sheet was pending, and that our count isn't out of sync.
    ASSERT(m_pendingStylesheets > 0);

    m_pendingStylesheets--;

[Pavel Feldman]

Created attachment 75200 [details]
[PATCH] Proposed fix.

[Dave Hyatt]

Comment on attachment 75200 [details]
[PATCH] Proposed fix.

r=me

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/css/CSSImportRule.cpp
Committed r72988

[WebKit Review Bot]

http://trac.webkit.org/changeset/72988 might have broken Qt Linux ARMv5 Release

[Pavel Feldman]

(this fix is being rolled out due to https://bugs.webkit.org/show_bug.cgi?id=50502)

[Eric Seidel (no email)]

Comment on attachment 75200 [details]
[PATCH] Proposed fix.

Marking r- since this was rolled out.

[Alexander Pavlov (apavlov)]

This is no longer crashing, fixed a while ago under a different bug.