WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
50502
REGRESSION (
r72988
): change to CSSImportRule breaks loading in iframes
https://bugs.webkit.org/show_bug.cgi?id=50502
Summary
REGRESSION (r72988): change to CSSImportRule breaks loading in iframes
Alice Liu
Reported
2010-12-03 16:18:13 PST
Created
attachment 75576
[details]
test case
http://trac.webkit.org/changeset/72988
seems to have broken loading of iframes with pages that use @import somewhere in their style. Attached a test case steps to repro: open attached test case Expected behavior: the page with url
http://www.nytimes.com/2010/11/07/education/07china-t.html?pagewanted=2&ref=education
should load in the iframe and then shortly afterward the document is overtaken by
http://www.nytimes.com/2010/11/07/education/07china-t.html
. Not sure why, but anyway this is what happens in shipping safari. 5.0.3 TOT behavior: nothing loads in iframe. side note: in the test case is a commented-out line that uses
http://www.rollingstone.com/politics/news/17390/119236?RS_show_page=1
. This page doesn't use @import and behaves the same way in shipping as TOT. it also just loads in the iframe and doens't overtake the whole document in both cases. <
rdar://problem/8728742
>
Attachments
test case
(637 bytes, text/html)
2010-12-03 16:18 PST
,
Alice Liu
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
mitz
Comment 1
2010-12-05 21:33:00 PST
See also
bug 50532
.
Alice Liu
Comment 2
2010-12-06 15:04:24 PST
Pavel, had you had any chance to take a look? Is it reasonable to consider reverting
r72988
? The consequences of the bug fix seem more serious than the fixed symptoms.
James Robinson
Comment 3
2010-12-06 16:23:53 PST
***
Bug 50532
has been marked as a duplicate of this bug. ***
James Robinson
Comment 4
2010-12-06 16:41:38 PST
***
Bug 50526
has been marked as a duplicate of this bug. ***
James Robinson
Comment 5
2010-12-06 20:52:56 PST
***
Bug 50613
has been marked as a duplicate of this bug. ***
Pavel Feldman
Comment 6
2010-12-06 22:55:29 PST
(In reply to
comment #2
)
> Pavel, had you had any chance to take a look? Is it reasonable to consider reverting
r72988
? The consequences of the bug fix seem more serious than the fixed symptoms.
Sorry, was flying across the ocean. Reverting this asap.
Pavel Feldman
Comment 7
2010-12-06 23:02:03 PST
Committing to
http://svn.webkit.org/repository/webkit/trunk
... M WebCore/ChangeLog M WebCore/css/CSSImportRule.cpp Committed
r73427
Alexey Proskuryakov
Comment 8
2010-12-07 01:37:12 PST
Eventually we should land a regression test for this problem. Pavel, would you be willing to make one?
Pavel Feldman
Comment 9
2010-12-07 01:50:33 PST
(In reply to
comment #8
)
> Eventually we should land a regression test for this problem. Pavel, would you be willing to make one?
Absolutely. We will need to fix the
http://trac.webkit.org/changeset/72988
and it'll require a test.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug