Bug 49973 - Make WebKit2 compile with !ENABLE(INSPECTOR)
Summary: Make WebKit2 compile with !ENABLE(INSPECTOR)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Andras Becsi
URL:
Keywords: Qt
Depends on:
Blocks: 49975
  Show dependency treegraph
 
Reported: 2010-11-23 07:08 PST by Andras Becsi
Modified: 2010-11-24 06:56 PST (History)
5 users (show)

See Also:


Attachments
proposed patch (34.74 KB, patch)
2010-11-23 08:12 PST, Andras Becsi
no flags Details | Formatted Diff | Diff
proposed patch v2 (31.88 KB, patch)
2010-11-23 08:46 PST, Andras Becsi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Becsi 2010-11-23 07:08:06 PST
WebKit2 does not compile with inspector disabled.
Comment 1 Andras Becsi 2010-11-23 08:12:08 PST
Created attachment 74667 [details]
proposed patch
Comment 2 Andras Becsi 2010-11-23 08:22:41 PST
Comment on attachment 74667 [details]
proposed patch

I realized that after r72606 I can simplify this a bit.
Comment 3 Andras Becsi 2010-11-23 08:46:25 PST
Created attachment 74673 [details]
proposed patch v2

No need for ifs in the Qt Api.
Comment 4 Laszlo Gombos 2010-11-24 05:04:48 PST
Do we really need these guards ? 

+#if ENABLE(INSPECTOR)
 class InspectorObject;
+#endif
Comment 5 WebKit Commit Bot 2010-11-24 05:57:44 PST
Comment on attachment 74673 [details]
proposed patch v2

Rejecting patch 74673 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'land-attachment', '--force-clean', '--ignore-builders', '--non-interactive', '--parent-command=commit-queue', 74673]" exit_code: 2
Last 500 characters of output:
bexec/git-core/git-svn line 558


Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
RA layer request failed: Server sent unexpected return value (500 Internal Server Error) in response to PUT request for '/repository/webkit/!svn/wrk/2a76944f-3c7f-41d5-9907-b010ee326c57/trunk/WebCore/ChangeLog' at /usr/local/git/libexec/git-core/git-svn line 558


Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1

Full output: http://queues.webkit.org/results/6372028
Comment 6 Andras Becsi 2010-11-24 06:39:28 PST
Committed r72666: <http://trac.webkit.org/changeset/72666>
Comment 7 Andras Becsi 2010-11-24 06:56:43 PST
Comment on attachment 74673 [details]
proposed patch v2

Before landing I removed the if's around forward declared classes since they are not needed as Laszlo pointed out correctly. Thanks.

Clearing flags.