Bug 49975 - Make build-webkit --minimal build with ENABLE_INSPECTOR=0
Summary: Make build-webkit --minimal build with ENABLE_INSPECTOR=0
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Andras Becsi
Depends on: 49942 49973
  Show dependency treegraph
Reported: 2010-11-23 07:58 PST by Andras Becsi
Modified: 2010-11-24 09:07 PST (History)
2 users (show)

See Also:

proposed patch (3.22 KB, patch)
2010-11-24 08:33 PST, Andras Becsi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Becsi 2010-11-23 07:58:29 PST
ENABLE_INSPECTOR=0 builds are frequently broken. Make it possible for the minimal bot to check the inspector guards.
Comment 1 Andras Becsi 2010-11-24 08:33:42 PST
Created attachment 74762 [details]
proposed patch
Comment 2 Csaba Osztrogonác 2010-11-24 08:34:53 PST
Comment on attachment 74762 [details]
proposed patch

Great fix, thx.
Comment 3 Andras Becsi 2010-11-24 08:36:55 PST
(In reply to comment #2)
> (From update of attachment 74762 [details])
> Great fix, thx.

This probably needs a clean build on the minimal bot.
Comment 4 WebKit Commit Bot 2010-11-24 09:07:30 PST
Comment on attachment 74762 [details]
proposed patch

Clearing flags on attachment: 74762

Committed r72676: <http://trac.webkit.org/changeset/72676>
Comment 5 WebKit Commit Bot 2010-11-24 09:07:36 PST
All reviewed patches have been landed.  Closing bug.