Bug 49964 – [gtk] Tests failing due to rounding problems in colors inside pixman

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alejandro G. Castro]

We have to check if this is a problem in the gtk port, when rendering of getting the results. Skipping until that point.

[Alejandro G. Castro]

I've send an email explaining what's going on in this situations, we can wait for some feedback from cairo people and decide about it:

http://lists.cairographics.org/archives/cairo/2010-December/021295.html

[Martin Robinson]

The tests this bug refers to may not be failing any longer, because of changes to the tests. In any case, we should list them here:

canvas-scale-drawImage-shadow.html
canvas-scale-fillRect-shadow.html
canvas-scale-fillPath-shadow.html
canvas-scale-strokePath-shadow.html

[Carlos Garcia Campos]

The tests failing for me in this moment that seem to be due to this bug are:

fast/canvas/canvas-getImageData.html
fast/canvas/canvas-fillPath-shadow.html
fast/canvas/canvas-strokePath-shadow.html
fast/canvas/canvas-scale-strokePath-shadow.html

[Carlos Garcia Campos]

*** Bug 55670 has been marked as a duplicate of this bug. ***

[Raphael Kubo da Costa (:rakuco)]

Right now, only fast/canvas/canvas-fillPath-shadow.html and fast/canvas/canvas-strokePath-shadow.html fail here.

[Martin Robinson]

(In reply to comment #5)
> Right now, only fast/canvas/canvas-fillPath-shadow.html and fast/canvas/canvas-strokePath-shadow.html fail here.

It may vary depending on your processor and Cairo version. :/ This is an annoying issue because it seems like the only way we can know if this is fixed or not is to unskip the tests.

[Zan Dobersek]

The following tests were found to be passing consistently after moving from using the Skipped list to using test_expectations.txt:
	fast/canvas/canvas-getImageData.html
	fast/canvas/canvas-scale-strokePath-shadow.html
	fast/canvas/canvas-strokePath-shadow.html
	fast/canvas/canvas-transforms-fillRect-shadow.html
	fast/canvas/rgba-parsing.html

Their expectations were removed in r116122[1] (covered by bug #85591). Tests that are covered by this bug and are still failing are the following:
	fast/canvas/canvas-fillPath-shadow.html

1: http://trac.webkit.org/changeset/116122

[Carlos Alberto Lopez Perez]

The test fast/canvas/canvas-fillPath-shadow.html pass now after the upgrade of GTK+, Cairo, Gdk-Pixbuf and GLib done in r186500 <http://trac.webkit.org/r186500>.

I have updated the expectations file on http://trac.webkit.org/changeset/186513

Should we close this bug as fixed?

[Martin Robinson]

(In reply to comment #8)
> The test fast/canvas/canvas-fillPath-shadow.html pass now after the upgrade
> of GTK+, Cairo, Gdk-Pixbuf and GLib done in r186500
> <http://trac.webkit.org/r186500>.
> 
> I have updated the expectations file on
> http://trac.webkit.org/changeset/186513
> 
> Should we close this bug as fixed?

Yes, probably. If the problems reappear is unlikely that people will remember this bug.