Bug 49925 – Simplify makeprop.pl

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Patrick R. Gansterer]

see patch

[Patrick R. Gansterer]

Created attachment 74573 [details]
Patch

[Andras Becsi]

LGTM, thanks for doing this!

Ossy, could you review, please?

[Andras Becsi]

Sorry, there is no explicit dependency.

[Patrick R. Gansterer]

(In reply to comment #3)
> Sorry, there is no explicit dependency.
Not sure. IMHO CSSPropertyNames.cpp needs HashTools.h to compile, but if a buildsystem realy needs it, it would fail too at the moment. So bug 49922 will "fix" this missing dependency. ;-)

[Andras Becsi]

(In reply to comment #4)
> (In reply to comment #3)
> > Sorry, there is no explicit dependency.
> Not sure. IMHO CSSPropertyNames.cpp needs HashTools.h to compile, but if a buildsystem realy needs it, it would fail too at the moment. So bug 49922 will "fix" this missing dependency. ;-)

Actually the file still exists in the EWS' build tree because of the incremental build, that's why it builds currently and it will still exist after the other patch, so this could cause troubles without a clean build.

And also, please remove the dependency to CSSPropertyNamesHash.h from GNUmakefile.am:

./WebCore/GNUmakefile.am:97:    DerivedSources/WebCore/CSSPropertyNamesHash.h \
./WebCore/GNUmakefile.am:4554:DerivedSources/WebCore/CSSPropertyNamesHash.h: DerivedSources/WebCore/CSSPropertyNames.cpp

[Andras Becsi]

> And also, please remove the dependency to CSSPropertyNamesHash.h from GNUmakefile.am.

Ah, you did it, sorry.

[Patrick R. Gansterer]

(In reply to comment #5)
> Actually the file still exists in the EWS' build tree because of the incremental build, that's why it builds currently and it will still exist after the other patch, so this could cause troubles without a clean build.

AFAIK all buildsystem generate all files before they compile, so that's not a real problem IMHO. But that the files still exists in the DerivedSources directory is a general problem with incremental builds :-(.


(In reply to comment #6)
> > And also, please remove the dependency to CSSPropertyNamesHash.h from GNUmakefile.am.
> 
> Ah, you did it, sorry.
Yes ;-)

[WebKit Commit Bot]

Comment on attachment 74573 [details]
Patch

Rejecting patch 74573 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 1
ERROR: Working directory has local commits, pass --force-clean to continue.

Full output: http://queues.webkit.org/results/6299043

[WebKit Commit Bot]

Comment on attachment 74573 [details]
Patch

Clearing flags on attachment: 74573

Committed r72672: <http://trac.webkit.org/changeset/72672>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.