WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 49908
[Qt] fast/regex/test1 fails on qt platform
https://bugs.webkit.org/show_bug.cgi?id=49908
Summary
[Qt] fast/regex/test1 fails on qt platform
Peter Varga
Reported
2010-11-22 06:55:47 PST
Created
attachment 74549
[details]
POC The fast/regex/test1 layout test is in the skipped list on qt platform. Reason is this test terminates when it prints a NUL character. The printing of the result of the matching of /abc\0def\00pqr\000xyz\0000AB/ pattern (Line: 455 in the test1-expected.txt) causes the problem. When it tries to print the first \0 in the result of the matching then the running of the test is aborted and it doesn't generate any more output therefore all latter tests fail. I think fast/regex/test4 have the same problem as well. I send a solution which uses the regular framework for testing thus the structure of these tests came closer to the other layout tests and the printing of the result doesn't terminate the running. I don't offer this patch for a review now becuase the comparison of the NUL character isn't successful therefore these tests are still failing. I haven't found a solution for the comparison problem yet. NOTE: This is on Qt platform and I didn't try it on mac yet.
Attachments
POC
(2.98 KB, patch)
2010-11-22 06:55 PST
,
Peter Varga
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Gavin Barraclough
Comment 1
2010-11-30 17:53:22 PST
Hopefully this problem may be resolved by
bug #50292
.
Csaba Osztrogonác
Comment 2
2010-12-01 00:15:08 PST
(In reply to
comment #1
)
> Hopefully this problem may be resolved by
bug #50292
.
Absolutely. Thanks for the fix.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug