WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
50292
Port PCRE regex tests to JSC harness / ECMA syntax
https://bugs.webkit.org/show_bug.cgi?id=50292
Summary
Port PCRE regex tests to JSC harness / ECMA syntax
Gavin Barraclough
Reported
2010-11-30 16:42:25 PST
LayoutTests/fast/regex currently contains a number of test cases ported from PCRE's test suites. There are two key problems with these tests: * They use their own harness, and cannot be run from jsc without building all of WebKit. * They expect PCRE expression syntax, including extended syntax, backwards assertions, etc. Rewrite all tests to comply to ECMA compatible syntax (ish - we support octal escapes), and use the normal 'shouldBe' test style.
Attachments
Add attachment
proposed patch, testcase, etc.
Gavin Barraclough
Comment 1
2010-11-30 17:52:54 PST
Fixed in
r72990
.
Alexey Proskuryakov
Comment 2
2010-11-30 22:41:13 PST
Gavin, did you check upstream PCRE for any interesting tests that were added since we imported the suite?
Gavin Barraclough
Comment 3
2010-12-01 11:45:08 PST
No, I didn't have time to look at this. My guess is that this would be an inefficient way to get high quality JS tests (since most of the PCRE tests seemed to focus on features not supported by ECMAScript). But feel free to give this a shot, if you disagree & think it may be worthwhile.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug