Bug 49771 – [chromium] Fix whitespace character handling in complex text on linux

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[James Simonsen]

[chromium] Fix whitespace character handling in complex text on linux

[James Simonsen]

Created attachment 74326 [details]
Patch

[James Simonsen]

Hi guys, Sorry to keep bugging you with these patches. I signed up to fix the fast/text layout tests for Chrome, so I'll periodically be sending out patches like this. If I should CC someone else, let me know.

[Tony Chang]

The updated images look correct to me (seem to match the mac results), but I'll leave the actual review to agl.

[Tony Chang]

Evan said he could do a review of this as well.

[Adam Langley]

Comment on attachment 74326 [details]
Patch

LGTM

[WebKit Commit Bot]

Comment on attachment 74326 [details]
Patch

Rejecting patch 74326 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2
Last 500 characters of output:
4 c++ com.apple.compilers.gcc.4_2
	CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/SVGTextContentElement.o /Projects/CommitQueue/WebCore/svg/SVGTextContentElement.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
	CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Release/WebCore.build/Objects-normal/x86_64/SVGTitleElement.o /Projects/CommitQueue/WebCore/svg/SVGTitleElement.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
(8 failures)


Full output: http://queues.webkit.org/results/6156084

[Tony Chang]

Comment on attachment 74326 [details]
Patch

Try again

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 74326 [details]:

compositing/iframes/overlapped-nested-iframes.html

Please file bugs against the tests.  These tests were authored by [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 74326 [details]
Patch

Clearing flags on attachment: 74326

Committed r72459: <http://trac.webkit.org/changeset/72459>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Eric Seidel (no email)]

Do we know what went wrong with the cq?  Its hard to tell from my phone...

[James Simonsen]

(In reply to comment #11)
> Do we know what went wrong with the cq?  Its hard to tell from my phone...

I couldn't find anything in the output. It said there were 8 failures, but there wasn't any indication of them in the log. The same thing happened to me on this bug: https://bugs.webkit.org/show_bug.cgi?id=49101