Bug 49101 - [Web Timing] Add unloadEventStart
Summary: [Web Timing] Add unloadEventStart
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://dvcs.w3.org/hg/webperf/raw-fil...
Keywords:
Depends on:
Blocks: 30685 48922
  Show dependency tree / graph
 
Reported: 2010-11-05 15:02 PDT by Tony Gentilcore
Modified: 2010-12-14 01:39 PST (History)
5 users (show)

See Also:

Attachments
Patch (16.00 KB, patch)
2010-11-08 22:29 PST, James Simonsen 		no flags Details | Formatted Diff | Diff
Patch (17.08 KB, patch)
2010-11-16 16:34 PST, James Simonsen 		fishd: review+
fishd: commit-queue-
Details | Formatted Diff | Diff
Patch (17.05 KB, patch)
2010-11-17 11:35 PST, James Simonsen 		fishd: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch (17.05 KB, patch)
2010-11-18 12:35 PST, James Simonsen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 James Simonsen 2010-11-08 22:29:42 PST 
Created attachment 73342 [details]
Patch
Comment 2 James Simonsen 2010-11-16 16:34:14 PST 
Created attachment 74057 [details]
Patch
Comment 3 James Simonsen 2010-11-16 16:34:41 PST 
Merged with my other recent patches.
Comment 4 Tony Gentilcore 2010-11-17 11:22:00 PST 
LGTM

Fishing for reviewers :-)
Comment 5 Darin Fisher (:fishd, Google) 2010-11-17 11:25:24 PST 
Comment on attachment 74057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74057&action=review

> WebCore/page/DOMWindow.h:278
> +        void dispatchWebTimedEvent(PassRefPtr<Event> event, Document* target, double* startTime, double* endTime);

actually, i'd probably just call this dispatchTimedEvent.
Comment 6 James Simonsen 2010-11-17 11:35:47 PST 
Created attachment 74139 [details]
Patch
Comment 7 Darin Fisher (:fishd, Google) 2010-11-18 09:42:10 PST 
Comment on attachment 74139 [details]
Patch

Thanks!
Comment 8 WebKit Commit Bot 2010-11-18 10:55:56 PST 
Comment on attachment 74139 [details]
Patch

Rejecting patch 74139 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2
Last 500 characters of output:
cts-normal/x86_64/ScriptController.o /Projects/CommitQueue/WebCore/bindings/js/ScriptController.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
	CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/ScriptDebugServer.o /Projects/CommitQueue/WebCore/bindings/js/ScriptDebugServer.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
(12 failures)

Use of uninitialized value $_[0] in join or string at /System/Library/Perl/5.10.0/File/Spec/Unix.pm line 81.

Full output: http://queues.webkit.org/results/6260014
Comment 9 James Simonsen 2010-11-18 12:35:53 PST 
Created attachment 74278 [details]
Patch
Comment 10 James Simonsen 2010-11-18 12:36:59 PST 
I wasn't able to reproduce that failure. Just to be safe, I uploaded a new patch after pulling in the latest changes and merging. Can someone set CQ+ again?
Comment 11 WebKit Commit Bot 2010-11-19 10:18:09 PST 
The commit-queue encountered the following flaky tests while processing attachment 74278 [details]:

inspector/timeline-layout.html

Please file bugs against the tests.  These tests were authored by pfeldman@chromium.org and yurys@chromium.org.  The commit-queue is continuing to process your patch.
Comment 12 WebKit Commit Bot 2010-11-19 10:19:48 PST 
Comment on attachment 74278 [details]
Patch

Clearing flags on attachment: 74278

Committed r72415: <http://trac.webkit.org/changeset/72415>
Comment 13 Eric Seidel (no email) 2010-12-14 01:39:35 PST 
Looks like this got landed and can be closed, no?

You should consider usign webkit-patch upload to upload patches as it will correctly obsolete old patches when uploading new ones.