Bug 49101 – [Web Timing] Add unloadEventStart

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Tony Gentilcore]

http://dvcs.w3.org/hg/webperf/raw-file/tip/specs/NavigationTiming/Overview.html#nt-unload-start

[James Simonsen]

Created attachment 73342 [details]
Patch

[James Simonsen]

Created attachment 74057 [details]
Patch

[James Simonsen]

Merged with my other recent patches.

[Tony Gentilcore]

LGTM

Fishing for reviewers :-)

[Darin Fisher (:fishd, Google)]

Comment on attachment 74057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=74057&action=review

> WebCore/page/DOMWindow.h:278
> +        void dispatchWebTimedEvent(PassRefPtr<Event> event, Document* target, double* startTime, double* endTime);

actually, i'd probably just call this dispatchTimedEvent.

[James Simonsen]

Created attachment 74139 [details]
Patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 74139 [details]
Patch

Thanks!

[WebKit Commit Bot]

Comment on attachment 74139 [details]
Patch

Rejecting patch 74139 from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sl', 'build', '--no-clean', '--no-update', '--build-style=both']" exit_code: 2
Last 500 characters of output:
cts-normal/x86_64/ScriptController.o /Projects/CommitQueue/WebCore/bindings/js/ScriptController.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
	CompileC /Projects/CommitQueue/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-normal/x86_64/ScriptDebugServer.o /Projects/CommitQueue/WebCore/bindings/js/ScriptDebugServer.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
(12 failures)

Use of uninitialized value $_[0] in join or string at /System/Library/Perl/5.10.0/File/Spec/Unix.pm line 81.

Full output: http://queues.webkit.org/results/6260014

[James Simonsen]

Created attachment 74278 [details]
Patch

[James Simonsen]

I wasn't able to reproduce that failure. Just to be safe, I uploaded a new patch after pulling in the latest changes and merging. Can someone set CQ+ again?

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 74278 [details]:

inspector/timeline-layout.html

Please file bugs against the tests.  These tests were authored by [e-mail] and [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 74278 [details]
Patch

Clearing flags on attachment: 74278

Committed r72415: <http://trac.webkit.org/changeset/72415>

[Eric Seidel (no email)]

Looks like this got landed and can be closed, no?

You should consider usign webkit-patch upload to upload patches as it will correctly obsolete old patches when uploading new ones.